fix(browser_adapter.ts): baseElement.getAttribute by PatrickJS · Pull Request #3214 · angular/angular

PatrickJS · 2015-07-23T06:32:16Z

currently throwing an error

Error during instantiation of LocationStrategy! (RouterLink -> Router -> Location -> LocationStrategy). 
ORIGINAL ERROR: TypeError: baseElement.attr is not a function

closes #3441

tbosch · 2015-07-24T22:41:31Z

modules/angular2/src/dom/browser_adapter.ts

Hey, could you add a unit test for this?

I added tests but ran into a problem with baseElement cache

Could you add a resetBaseElement method to the DomAdapter (and all implementations). You can narrow it down to only the JS/Dart adapter via if (DOM.supportsDOMEvents()) {...}

I think I did something wrong here when adding resetBaseElement and getBaseHref to the other adapters

PatrickJS · 2015-07-25T00:00:55Z

modules/angular2/test/dom/dom_adapter_spec.ts

this fails due to baseElement being cache from the prevous test

PatrickJS · 2015-08-01T05:20:20Z

I'm having trouble correctly testing this in Dart. Can anyone help?

btford · 2015-08-03T18:26:26Z

@gdi2290 sure– what's the problem?

PatrickJS · 2015-08-03T21:31:58Z

@btford with Dart I'm trying not run these tests for Dart (since it's only in js atm). Using if (DOM.supportsDOMEvents) travis dart error doesn't seem to work when avoiding the Dart version. I recall an environment variable (IS_DARTIUM) that is used to narrow down a test to js so should I use that rather than supportsDOMEvents as Tobias suggested? Unless he meant for me to write out getBaseHref for Dart too (I know he is on vaca this week)

btford · 2015-08-04T17:57:58Z

Unless he meant for me to write out getBaseHref for Dart too (I know he is on vaca this week)

I think that's what he meant, but I'm not sure. :/

btford · 2015-08-05T19:35:18Z

Moving this to alpha-35.

currently throwing an error ```error Error during instantiation of LocationStrategy! (RouterLink -> Router -> Location -> LocationStrategy). ORIGINAL ERROR: TypeError: baseElement.attr is not a function ```

PatrickJS · 2015-08-12T05:23:06Z

@btford can you take over this PR? you can either close and recreate it or push to my repo git push patrickjs yourbranch:patch-1 for it to show up in this PR. All that's left is Dart support and I don't want this PR to live through another version :/

btford · 2015-08-18T17:40:39Z

Yes, I'll get this in today.

btford · 2015-08-18T18:10:21Z

Fixed and pushed to presubmit. 👍

PatrickJS · 2015-08-18T19:47:18Z

thanks! 👍

googlebot added the cla: yes label Jul 23, 2015

tbosch reviewed Jul 24, 2015
View reviewed changes

tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 24, 2015

PatrickJS force-pushed the patch-1 branch from 524d4d7 to 8110731 Compare July 24, 2015 23:59

PatrickJS reviewed Jul 25, 2015
View reviewed changes

PatrickJS force-pushed the patch-1 branch 2 times, most recently from a9cb434 to b44620a Compare July 28, 2015 00:22

PatrickJS mentioned this pull request Aug 1, 2015

HTML5LocationStrategy doesn't work (even with base attr) #3441

Closed

btford self-assigned this Aug 3, 2015

btford added this to the alpha-34 milestone Aug 3, 2015

btford added comp: router type: bug/fix effort2: days labels Aug 3, 2015

PatrickJS force-pushed the patch-1 branch 2 times, most recently from f32a1ad to e4379ec Compare August 3, 2015 21:04

btford modified the milestones: alpha-35, alpha-34 Aug 5, 2015

fix(browser_adapter.ts): baseElement.getAttribute

e8c3e34

currently throwing an error ```error Error during instantiation of LocationStrategy! (RouterLink -> Router -> Location -> LocationStrategy). ORIGINAL ERROR: TypeError: baseElement.attr is not a function ```

PatrickJS force-pushed the patch-1 branch from e4379ec to e8c3e34 Compare August 12, 2015 05:18

btford closed this in 235dec2 Aug 18, 2015

PatrickJS deleted the patch-1 branch August 18, 2015 19:18

Conversation

PatrickJS commented Jul 23, 2015

Uh oh!

tbosch Jul 24, 2015

Choose a reason for hiding this comment

Uh oh!

PatrickJS Jul 25, 2015

Choose a reason for hiding this comment

Uh oh!

tbosch Jul 27, 2015

Choose a reason for hiding this comment

Uh oh!

PatrickJS Jul 30, 2015

Choose a reason for hiding this comment

Uh oh!

PatrickJS Jul 25, 2015

Choose a reason for hiding this comment

Uh oh!

PatrickJS commented Aug 1, 2015

Uh oh!

btford commented Aug 3, 2015

Uh oh!

PatrickJS commented Aug 3, 2015

Uh oh!

btford commented Aug 4, 2015

Uh oh!

btford commented Aug 5, 2015

Uh oh!

PatrickJS commented Aug 12, 2015

Uh oh!

btford commented Aug 18, 2015

Uh oh!

btford commented Aug 18, 2015

Uh oh!

PatrickJS commented Aug 18, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants