feat(router): introduce matrix params#2989
Closed
matsko wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
matsko
force-pushed
the
router_matrix_params
branch
from
29d73a3 to
53e963b
Compare
Contributor
There was a problem hiding this comment.
use StringMapWrapper.create()
Contributor
|
General approach looks good, just lots of little things to fix. Let me know when CI is passing and I'll take another look. |
btford
added
the
action: cleanup
matsko
force-pushed
the
router_matrix_params
branch
4 times, most recently
from
c1f92dc to
a130c87
Compare
Contributor
|
Looks good! ~~~Merge when green.~~~ 👏 🚀 ✌️ Looks like one file needs formatting. Fix that and merge (no need to run the tests again). |
matsko
force-pushed
the
router_matrix_params
branch
from
a130c87 to
a3309b2
Compare
Contributor
Author
|
We're almost there 🐈 |
matsko
force-pushed
the
router_matrix_params
branch
from
a3309b2 to
430c544
Compare
Closes angular#2774 Closes angular#2989
matsko
force-pushed
the
router_matrix_params
branch
from
430c544 to
f084501
Compare
Contributor
Author
|
Finally! 🐈 🐈 🐈 🐕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.