feat(NgStyle): add new NgStyle directive#2665
feat(NgStyle): add new NgStyle directive#2665pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Conversation
pkozlowski-opensource
commented
Jun 21, 2015
pkozlowski-opensource
commented
There was a problem hiding this comment.
I'm not familiar with the pipe concept yet, but does keyValDiff also support Arrays or only Maps?
(This was the Angular 1.0 behavior)
There was a problem hiding this comment.
@matanlurey nope, keyValDiff works only with the Map-like objects. But reading your comment I'm getting an impression that you were thinking about ngClass, since I can see only maps being supported in ng1 (both JS and Dart)
If you are interested in the ngClass equivalent, the relevant PR is this: #2664)
There was a problem hiding this comment.
FWIW, ngStyle in ng1 does support expressions (not only maps).
There was a problem hiding this comment.
(But only expressions that evaluate to maps, so it's not far off 😃)
There was a problem hiding this comment.
Right, this is exactly what this version does as well :-)
naomiblack
added
the
action: cleanup
pkozlowski-opensource
force-pushed
the
ngstyle
branch
2 times, most recently
from
78bc76d to
e916b06
Compare
|
@naomiblack cleaned up code and addressed comments. This needs another round of review (I can see that @vsavkin is already assigned and he knows this part best) |
pkozlowski-opensource
added
action: review
pkozlowski-opensource
force-pushed
the
ngstyle
branch
from
e916b06 to
acc4324
Compare
There was a problem hiding this comment.
Should it be commented out?
There was a problem hiding this comment.
Nope, good catch!
vsavkin
added
pr_state: LGTM
action: cleanup
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
6 participants
