feat(transformers): provide a flag to disable inlining views#2658
feat(transformers): provide a flag to disable inlining views#2658TedSander wants to merge 1 commit intoangular:masterfrom
Conversation
|
@jakemac53 what do you think of this? Isn't urgent. Just a nice to have for environments that don't want to inline html. Example when they want to use http 2.0 server push. |
|
It should be fine, we can convert all urls to package: urls in the transformer and then we don't need mirrors in the deployed version. |
|
Cool. Then should we review it and check it in before too much drift? |
|
Oh, somehow I missed that you actually had a cl for this :). Reviewing it now... |
TedSander
force-pushed
the
inlineTemplatesFlag
branch
from
9f1c7d8 to
6ceaca1
Compare
There was a problem hiding this comment.
It would probably be good here to validate that a package: url was passed, unless we add in logic to automatically convert relative/absolute urls to package: urls.
There was a problem hiding this comment.
We are going to need the logic to automatically convert relative/absolute urls to package:urls. Also need to support web assets which we aren't doing currently. I'd rather do those in separate pull requests.
There was a problem hiding this comment.
Ok, can you file a bug for converting urls? I just want to make sure that doesn't fall through the cracks.
|
Please rebase ontop of master and merge... |
tbosch
added
the
action: cleanup
TedSander
force-pushed
the
inlineTemplatesFlag
branch
2 times, most recently
from
e26fb57 to
8b34198
Compare
|
Rebased and merged to master Comments from the review on Reviewable.io |
|
Has this actually been merged in yet? |
|
No I don't think so... I'll ping tbosch directly tomorrow. |
TedSander
force-pushed
the
inlineTemplatesFlag
branch
from
8b34198 to
708fbe3
Compare
Add a flag to allow a user to disable inlining css/html content into the views.
|
@munificent This is merged |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Add a flag to allow a user to disable inlining css/html content into the views.