X Tutup
Skip to content

Render reflectection#2637

Closed
tbosch wants to merge 2 commits intoangular:masterfrom
tbosch:render-reflect
Closed

Render reflectection#2637
tbosch wants to merge 2 commits intoangular:masterfrom
tbosch:render-reflect

Conversation

@tbosch
Copy link
Copy Markdown
Contributor

@tbosch tbosch commented Jun 19, 2015

No description provided.

@tbosch tbosch changed the title [WIP] Render reflectection Render reflectection Jun 22, 2015
tbosch
tbosch reviewed Jun 22, 2015
View reviewed changes
modules/angular2/src/facade/collection.ts Outdated
Copy link
Copy Markdown
Contributor Author

@tbosch tbosch Jun 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix Map.keys

@tbosch tbosch added pr_state: LGTM action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Jun 22, 2015
@tbosch
Copy link
Copy Markdown
Contributor Author

tbosch commented Jun 22, 2015

Reviewed with @vsavkin in person.

@tbosch tbosch force-pushed the render-reflect branch 2 times, most recently from 3418dfd to 934ec45 Compare June 23, 2015 00:59
@tbosch
feat(render): don’t use the reflector for setting properties
666828d 
BREAKING CHANGES:
- host actions don't take an expression as value any more but only a method name,
  and assumes to get an array via the EventEmitter with the method arguments.
- Renderer.setElementProperty does not take `style.`/... prefixes any more.
  Use the new methods `Renderer.setElementAttribute`, ... instead
@tbosch tbosch closed this in 0a51ccb Jun 23, 2015
@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Jun 23, 2015

@tbosch was there any special technical reason to kill [foo.style="exp"? Or was it just to make the whole system more consistent?

@tbosch
Copy link
Copy Markdown
Contributor Author

tbosch commented Jun 23, 2015

It's still there, but as style.foo. Was it foo.style before?
On Tue, Jun 23, 2015 at 3:34 AM Pawel Kozlowski notifications@github.com
wrote:

@tbosch https://github.com/tbosch was there any special technical
reason to kill [foo.style="exp"? Or was it just to make the whole system
more consistent?

—
Reply to this email directly or view it on GitHub
#2637 (comment).

@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Jun 23, 2015

@tbosch oh, sorry, I just got confused by the breaking changes section in 0a51ccb. All in order!

@tbosch tbosch deleted the render-reflect branch June 23, 2015 18:29
jimthedev pushed a commit to jimthedev/angular that referenced this pull request Jun 30, 2015
@tbosch @jimthedev
feat(render): don’t use the reflector for setting properties
9e64eb2 
BREAKING CHANGES:
- host actions don't take an expression as value any more but only a method name,
  and assumes to get an array via the EventEmitter with the method arguments.
- Renderer.setElementProperty does not take `style.`/... prefixes any more.
  Use the new methods `Renderer.setElementAttribute`, ... instead

Part of angular#2476
Closes angular#2637
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbosch @pkozlowski-opensource @googlebot
X Tutup