X Tutup
Skip to content

feat(benchpress): add mean frame time metric#2474

Closed
goderbauer wants to merge 1 commit intoangular:masterfrom
goderbauer:master
Closed

feat(benchpress): add mean frame time metric#2474
goderbauer wants to merge 1 commit intoangular:masterfrom
goderbauer:master

Conversation

@goderbauer
Copy link
Copy Markdown
Contributor

@goderbauer goderbauer commented Jun 11, 2015

This is useful to measure the smoothness of animations and scrolling actions.

part of #821

tbosch
tbosch reviewed Jun 11, 2015
View reviewed changes
modules/benchpress/src/metric/perflog_metric.ts Outdated
Copy link
Copy Markdown
Contributor

@tbosch tbosch Jun 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should move this into the if call further down in Line 221: You don't want to capture start/end marks outside of the execute function and don't want to capture events from other processes (which is very unlikely though)...

@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Jun 11, 2015

Could you add a top level comment on ChromeDriverExtension which traceCategories should be set to use this new metric? And ity would be nice to add the already used ones v8,blink.console,disabled-by-default-devtools.timeline as well.

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 11, 2015
@goderbauer
feat(benchpress): add mean frame time metric
009cda0 
This is useful to measure the smoothness of animations and scrolling actions.

part of angular#821
@goderbauer
Copy link
Copy Markdown
Contributor Author

goderbauer commented Jun 12, 2015

Updated PR after addressing comments. PTAL. Thanks.

@tbosch tbosch closed this in 6834c49 Jun 12, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @tbosch @googlebot
X Tutup