fix(dartfmt): don't break win32 command line limit#2420
Closed
caitp wants to merge 1 commit intoangular:masterfrom
Closed
fix(dartfmt): don't break win32 command line limit#2420caitp wants to merge 1 commit intoangular:masterfrom
caitp wants to merge 1 commit intoangular:masterfrom
Conversation
vsavkin
added
the
action: review
Contributor
|
how about detecting first run instead (similar to how TS plugin does it) and running the formatter on the whole directory rather than individual files during the first run? |
IgorMinar
added
the
area: build & ci
Contributor
Author
|
@IgorMinar updated as requested |
tools/broccoli/broccoli-dartfmt.ts
Outdated
Contributor
Author
There was a problem hiding this comment.
clang-format does some weird stuff ._.
caitp
force-pushed
the
issue-1875
branch
2 times, most recently
from
6569e67 to
8e4f36f
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give that a try?
Closes #1875