perf(RouterLink): use hostListeners for click#2401
Closed
PatrickJS wants to merge 1 commit intoangular:masterfrom
Closed
perf(RouterLink): use hostListeners for click#2401PatrickJS wants to merge 1 commit intoangular:masterfrom
PatrickJS wants to merge 1 commit intoangular:masterfrom
Conversation
PatrickJS
force-pushed
the
patch-8
branch
2 times, most recently
from
c5450a1 to
64f76ac
Compare
Contributor
There was a problem hiding this comment.
Why are we using DOM instead of hostListeners? Then, we don't need to cancel it.
vsavkin
added
the
action: review
with a `<router-outlet>` and lots of `router-link` you start to see noticeable lag since we’re not removing the listener
PatrickJS
changed the title
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with a
<router-outlet>and lots ofrouter-linkyou start to see noticeable lag