X Tutup
Skip to content

Unparser#2395

Closed
vicb wants to merge 3 commits intoangular:masterfrom
vicb:0606-printer
Closed

Unparser#2395
vicb wants to merge 3 commits intoangular:masterfrom
vicb:0606-printer

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Jun 6, 2015

fixes #1949

/cc @gdi2290

@vicb vicb added feature Label used to distinguish feature request from other issues comp: core/change_detection action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 6, 2015
@vicb vicb force-pushed the 0606-printer branch 4 times, most recently from b42e9f7 to 7ebf982 Compare June 6, 2015 13:08
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Jun 7, 2015

Could we rename his into serializer, instead of unparser?

@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Jun 7, 2015

Or maybe formatter?

@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Jun 7, 2015

Or stringifier?

@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jun 7, 2015

I have also wondered about the naming and done a bit of searching. This is an unparser.

@vsavkin
Copy link
Copy Markdown
Contributor

vsavkin commented Jun 8, 2015

As far as I understand the only reason for this is to provide better error messages when change detection throws. If so, should not we just show the source we parsed the AST from?

@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jun 8, 2015

The main reason why I've created this is to help with parser tests (see #2348).

This can also probably be used in place of ASTWithSource, but not the intent of this PR

@vsavkin
Copy link
Copy Markdown
Contributor

vsavkin commented Jun 8, 2015

I can see how it is useful for tests. Should it be in the tests directory then?

@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jun 9, 2015

@vsavkin I've moved the UnParser to the test folder in the last commit, PTAL.

@vicb vicb added this to the alpha-27 milestone Jun 9, 2015
@vicb vicb closed this in 331a051 Jun 10, 2015
@vicb vicb deleted the 0606-printer branch December 3, 2015 16:54
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes feature Label used to distinguish feature request from other issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AST.toString() === 'AST'?

4 participants

X Tutup