feat(forms.ts): formInjectables with FormBuilder#2367
Closed
PatrickJS wants to merge 1 commit intoangular:masterfrom
Closed
feat(forms.ts): formInjectables with FormBuilder#2367PatrickJS wants to merge 1 commit intoangular:masterfrom
PatrickJS wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
|
Please run clang-format. |
vicb
added
the
action: cleanup
Contributor
Author
|
thanks @vicb, I saw the no_dart error and just assumed it was okay since it worked in Dart. I pushed it up with the correct format |
modules/angular2/forms.ts
Outdated
Contributor
There was a problem hiding this comment.
I don't think it will work in Dart. You should use: export const formInjectables: List<any> = CONST_EXPR([FormBuilder]);
Contributor
Author
|
this should be good for Dart now |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.