fix: corrected var/# parsing in template#2084
fix: corrected var/# parsing in template#2084mhevery wants to merge 3 commits intoangular:masterfrom
Conversation
There was a problem hiding this comment.
wouldn't this work by only removing the enclosing if (!EOF) { ...}
might need to add an !EOF in the else if
var name = '\$implicit';
var expression = null;
if (keyIsVar) {
if (this.optionalOperator("=")) {
name = this.expectTemplateBindingKey();
}
} else if (this.next !== EOF && !this.peekKeywordVar()) {
var start = this.inputIndex;
var ast = this.parsePipe();
var source = this.input.substring(start, this.inputIndex);
expression = new ASTWithSource(ast, source, this.location);
}
There was a problem hiding this comment.
Good idea, implemented
vicb
added
@lgtm
action: merge
|
You need to run |
|
@mhevery Why does the parser needs to explicitly set
|
|
The issues is that Who should set |
|
LGTM after the duplicated test is updated (see inline comment |
|
@mhevery could you rebase? |
|
removing merge as unit tests need updates |
mhevery
removed
the
action: cleanup
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
No description provided.