X Tutup
Skip to content

Commit eb7839e

Browse files
committed
fix(build): temporarily test dart with dart2js instead of pub serve
Should be changed back when #4316 is resolved.
1 parent f600d88 commit eb7839e

File tree

3 files changed

+19
-16
lines changed

3 files changed

+19
-16
lines changed

scripts/ci/test_e2e_dart.sh

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,15 @@ function killServer () {
1515
# Serving pre-compiled dart JS takes an extra 15m.
1616
# So we do this only for post-commit testing.
1717
# Pull requests test with Dartium and pub serve
18-
if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then
19-
# WARNING: the build/pubbuild.dart task is assumed to have been run before, in test_server_dart.sh
18+
# TODO(jeffbcross): restore conditional dart2js/pubserve #4316
19+
#if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then
20+
# WARNING: the build/pubbuild.dart task is assumed to have been run before, in test_server_dart.sh
2021
./node_modules/.bin/gulp serve.js.dart2js&
2122
serverPid=$!
22-
else
23-
./node_modules/.bin/gulp serve.dart&
24-
serverPid=$!
25-
fi
23+
#else
24+
# ./node_modules/.bin/gulp serve.dart&
25+
# serverPid=$!
26+
#fi
2627

2728
./node_modules/.bin/gulp build.css.material&
2829

scripts/ci/test_perf.sh

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,15 @@ function killServer () {
1616
# Serving pre-compiled dart JS takes an extra 15m.
1717
# So we do this only for post-commit testing.
1818
# Pull requests test with Dartium and pub serve
19-
if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then
19+
# TODO(jeffbcross): restore conditional dart2js/pubserve #4316
20+
#if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then
2021
./node_modules/.bin/gulp build/pubbuild.dart
2122
./node_modules/.bin/gulp serve.js.prod serve.js.dart2js&
2223
serverPid=$!
23-
else
24-
./node_modules/.bin/gulp serve.js.prod serve.dart&
25-
serverPid=$!
26-
fi
24+
#else
25+
# ./node_modules/.bin/gulp serve.js.prod serve.dart&
26+
# serverPid=$!
27+
#fi
2728

2829
trap killServer EXIT
2930

scripts/ci/test_server_dart.sh

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,15 @@ ps -ef | grep webdriver-manager
1414
# Serving pre-compiled dart JS takes an extra 15m.
1515
# So we do this only for post-commit testing.
1616
# Pull requests test with Dartium and pub serve
17-
if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then
17+
# TODO(jeffbcross): restore conditional dart2js/pubserve #4316
18+
#if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then
1819
./node_modules/.bin/gulp build/pubbuild.dart
1920
./node_modules/.bin/gulp serve.js.dart2js&
2021
serverPid=$!
21-
else
22-
./node_modules/.bin/gulp serve.dart&
23-
serverPid=$!
24-
fi
22+
#else
23+
# ./node_modules/.bin/gulp serve.dart&
24+
# serverPid=$!
25+
#fi
2526

2627
function killAllServers () {
2728
kill $serverPid

0 commit comments

Comments
 (0)
X Tutup