fix(core): add detail to dehydrated detector exception

justindujardin · IgorMinar · commit e7ad03cba669 · 2016-02-08T17:17:37.000-08:00
- at least I know what component is causing the error with this. without it the exception is so generic that it's not useful. Closes #6939
diff --git a/modules/angular2/src/core/change_detection/abstract_change_detector.ts b/modules/angular2/src/core/change_detection/abstract_change_detector.ts
@@ -73,7 +73,7 @@ export class AbstractChangeDetector<T> implements ChangeDetector {
 
   handleEvent(eventName: string, elIndex: number, event: any): boolean {
     if (!this.hydrated()) {
-      this.throwDehydratedError();
+      this.throwDehydratedError(`${this.id} -> ${eventName}`);
     }
     try {
       var locals = new Map<string, any>();
@@ -130,7 +130,7 @@ export class AbstractChangeDetector<T> implements ChangeDetector {
   // facilitate error reporting.
   detectChangesInRecords(throwOnChange: boolean): void {
     if (!this.hydrated()) {
-      this.throwDehydratedError();
+      this.throwDehydratedError(this.id);
     }
     try {
       this.detectChangesInRecordsInternal(throwOnChange);
@@ -362,7 +362,7 @@ export class AbstractChangeDetector<T> implements ChangeDetector {
                                                               oldValue, newValue, null);
   }
 
-  throwDehydratedError(): void { throw new DehydratedException(); }
+  throwDehydratedError(detail: string): void { throw new DehydratedException(detail); }
 
   private _currentBinding(): BindingTarget {
     return this.bindingTargets[this.propertyBindingIndex];
diff --git a/modules/angular2/src/core/change_detection/exceptions.ts b/modules/angular2/src/core/change_detection/exceptions.ts
@@ -91,7 +91,7 @@ export class ChangeDetectionError extends WrappedException {
  * This is an internal Angular error.
  */
 export class DehydratedException extends BaseException {
-  constructor() { super('Attempt to use a dehydrated detector.'); }
+  constructor(details: string) { super(`Attempt to use a dehydrated detector: ${details}`); }
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ export class ChangeDetectionError extends WrappedException {`
`91`	`91`	`* This is an internal Angular error.`
`92`	`92`	`*/`
`93`	`93`	`export class DehydratedException extends BaseException {`
`94`		`- constructor() { super('Attempt to use a dehydrated detector.'); }`
	`94`	+ constructor(details: string) { super(`Attempt to use a dehydrated detector: ${details}`); }
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`/**`