fix(benchmarks): remove reference to String.prototype.contains()

caitp · caitp · commit b6ee20846b10 · 2015-08-12T23:16:57.000Z
https://github.com/tc39/tc39-notes/blob/master/es6/2014-11/nov-18.md#51--44-arrayprototypecontains-and-stringprototypecontains removed String.prototype.contains() from standard, and is not implemented in most runtimes (SpiderMonkey still being an exception). Closes #3570
diff --git a/modules/benchmarks/src/naive_infinite_scroll/common.ts b/modules/benchmarks/src/naive_infinite_scroll/common.ts
@@ -1,5 +1,5 @@
 import {Math} from 'angular2/src/facade/math';
-
+import {StringWrapper} from 'angular2/src/facade/lang';
 import {ListWrapper, Map, MapWrapper} from 'angular2/src/facade/collection';
 
 export var ITEMS = 1000;
@@ -86,7 +86,7 @@ export class RawEntity {
   }
 
   remove(key: string) {
-    if (!key.contains('.')) {
+    if (!StringWrapper.contains(key, '.')) {
       return MapWrapper.delete(this._data, key);
     }
     var pieces = key.split('.');

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`import {Math} from 'angular2/src/facade/math';`
`2`		`-`
	`2`	`+import {StringWrapper} from 'angular2/src/facade/lang';`
`3`	`3`	`import {ListWrapper, Map, MapWrapper} from 'angular2/src/facade/collection';`
`4`	`4`
`5`	`5`	`export var ITEMS = 1000;`
`@@ -86,7 +86,7 @@ export class RawEntity {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`remove(key: string) {`
`89`		`- if (!key.contains('.')) {`
	`89`	`+ if (!StringWrapper.contains(key, '.')) {`
`90`	`90`	`return MapWrapper.delete(this._data, key);`
`91`	`91`	`}`
`92`	`92`	`var pieces = key.split('.');`