fix(dart): @Proxy is a value, not a factory

alexeagle · alexeagle · commit b4a062983bbd · 2015-08-06T10:02:49.000-07:00
Previously I added parens everywhere to make this @Proxy() because our typing indicated it was a function that returned a decorator, but this breaks dart. Instead, the typing needs to be changed. Fixes #3494
diff --git a/modules/angular2/src/mock/location_mock.ts b/modules/angular2/src/mock/location_mock.ts
@@ -6,7 +6,7 @@ import {List, ListWrapper} from 'angular2/src/facade/collection';
 import {Location} from 'angular2/src/router/location';
 
 
-@proxy()
+@proxy
 @IMPLEMENTS(Location)
 export class SpyLocation extends SpyObject {
   urlChanges: List<string>;
diff --git a/modules/angular2/src/test_lib/test_lib.ts b/modules/angular2/src/test_lib/test_lib.ts
@@ -12,9 +12,7 @@ import {createTestInjector, FunctionWithParamTokens, inject} from './test_inject
 
 export {inject} from './test_injector';
 
-export function proxy(): ClassDecorator {
-  return (t) => t;
-}
+export var proxy: ClassDecorator = (t) => t;
 
 var _global: jasmine.GlobalPolluter = <any>(typeof window === 'undefined' ? global : window);
 
diff --git a/modules/angular2/test/change_detection/pipes/observable_pipe_spec.ts b/modules/angular2/test/change_detection/pipes/observable_pipe_spec.ts
@@ -117,7 +117,7 @@ export function main() {
   });
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(ChangeDetectorRef)
 class SpyChangeDetectorRef extends SpyObject {
   constructor() { super(ChangeDetectorRef); }
diff --git a/modules/angular2/test/change_detection/pipes/promise_pipe_spec.ts b/modules/angular2/test/change_detection/pipes/promise_pipe_spec.ts
@@ -119,7 +119,7 @@ export function main() {
   });
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(ChangeDetectorRef)
 class SpyChangeDetectorRef extends SpyObject {
   constructor() { super(ChangeDetectorRef); }
diff --git a/modules/angular2/test/core/compiler/compiler_spec.ts b/modules/angular2/test/core/compiler/compiler_spec.ts
@@ -658,14 +658,14 @@ class DirectiveWithAttributes {
   constructor(@Attribute('someAttr') someAttr: String) {}
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(RenderCompiler)
 class SpyRenderCompiler extends SpyObject {
   constructor() { super(RenderCompiler); }
   noSuchMethod(m) { return super.noSuchMethod(m) }
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(DirectiveResolver)
 class SpyDirectiveResolver extends SpyObject {
   constructor() { super(DirectiveResolver); }
diff --git a/modules/angular2/test/core/compiler/element_injector_spec.ts b/modules/angular2/test/core/compiler/element_injector_spec.ts
@@ -48,7 +48,7 @@ import {ElementRef} from 'angular2/src/core/compiler/element_ref';
 import {DynamicChangeDetector, ChangeDetectorRef, Parser, Lexer} from 'angular2/src/change_detection/change_detection';
 import {QueryList} from 'angular2/src/core/compiler/query_list';
 
-@proxy()
+@proxy
 @IMPLEMENTS(AppView)
 class DummyView extends SpyObject {
   changeDetector;
@@ -59,7 +59,7 @@ class DummyView extends SpyObject {
   noSuchMethod(m) { return super.noSuchMethod(m); }
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(ElementRef)
 class DummyElementRef extends SpyObject {
   boundElementIndex: number = 0;
diff --git a/modules/angular2/test/core/compiler/proto_view_factory_spec.ts b/modules/angular2/test/core/compiler/proto_view_factory_spec.ts
@@ -199,7 +199,7 @@ function createRenderViewportElementBinder(nestedProtoView) {
   return new renderApi.ElementBinder({nestedProtoView: nestedProtoView});
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(ChangeDetection)
 class ChangeDetectionSpy extends SpyObject {
   constructor() { super(ChangeDetection); }
diff --git a/modules/angular2/test/core/compiler/view_container_ref_spec.ts b/modules/angular2/test/core/compiler/view_container_ref_spec.ts
@@ -62,15 +62,15 @@ export function main() {
   });
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(AppView)
 class AppViewSpy extends SpyObject {
   viewContainers: AppViewContainer[] = [null];
   constructor() { super(AppView); }
   noSuchMethod(m) { return super.noSuchMethod(m) }
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(AppViewManager)
 class AppViewManagerSpy extends SpyObject {
   constructor() { super(AppViewManager); }
diff --git a/modules/angular2/test/core/compiler/view_manager_spec.ts b/modules/angular2/test/core/compiler/view_manager_spec.ts
@@ -507,21 +507,21 @@ export function main() {
   });
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(Renderer)
 class SpyRenderer extends SpyObject {
   constructor() { super(Renderer); }
   noSuchMethod(m) { return super.noSuchMethod(m) }
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(AppViewPool)
 class SpyAppViewPool extends SpyObject {
   constructor() { super(AppViewPool); }
   noSuchMethod(m) { return super.noSuchMethod(m) }
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(AppViewListener)
 class SpyAppViewListener extends SpyObject {
   constructor() { super(AppViewListener); }
diff --git a/modules/angular2/test/core/compiler/view_manager_utils_spec.ts b/modules/angular2/test/core/compiler/view_manager_utils_spec.ts
@@ -353,29 +353,29 @@ export function createEmbeddedPv(binders: ElementBinder[] = null) {
 class SomeComponent {
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(ProtoElementInjector)
 class SpyProtoElementInjector extends SpyObject {
   index: number;
   constructor(public parent: ProtoElementInjector) { super(ProtoElementInjector); }
   noSuchMethod(m) { return super.noSuchMethod(m) }
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(ElementInjector)
 class SpyElementInjector extends SpyObject {
   constructor(public parent: ElementInjector) { super(ElementInjector); }
   noSuchMethod(m) { return super.noSuchMethod(m) }
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(PreBuiltObjects)
 class SpyPreBuiltObjects extends SpyObject {
   constructor() { super(PreBuiltObjects); }
   noSuchMethod(m) { return super.noSuchMethod(m) }
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(Injector)
 class SpyInjector extends SpyObject {
   constructor() { super(Injector); }
diff --git a/modules/angular2/test/router/router_link_spec.ts b/modules/angular2/test/router/router_link_spec.ts
@@ -79,7 +79,7 @@ class TestComponent {
 }
 
 
-@proxy()
+@proxy
 @IMPLEMENTS(Location)
 class DummyLocation extends SpyObject {
   noSuchMethod(m) { return super.noSuchMethod(m) }
@@ -92,7 +92,7 @@ function makeDummyLocation() {
 }
 
 
-@proxy()
+@proxy
 @IMPLEMENTS(Router)
 class DummyRouter extends SpyObject {
   noSuchMethod(m) { return super.noSuchMethod(m) }
diff --git a/modules/angular2/test/router/router_spec.ts b/modules/angular2/test/router/router_spec.ts
@@ -175,7 +175,7 @@ export function main() {
   });
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(RouterOutlet)
 class DummyOutlet extends SpyObject {
   noSuchMethod(m) { return super.noSuchMethod(m) }
diff --git a/modules/angular2/test/services/ruler_spec.ts b/modules/angular2/test/services/ruler_spec.ts
@@ -58,15 +58,15 @@ export function main() {
   });
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(ElementRef)
 class SpyElementRef extends SpyObject {
   nativeElement;
   constructor() { super(ElementRef); }
   noSuchMethod(m) { return super.noSuchMethod(m) }
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(DomAdapter)
 class SpyDomAdapter extends SpyObject {
   constructor() { super(DomAdapter); }
diff --git a/modules/angular2/test/test_lib/test_lib_spec.ts b/modules/angular2/test/test_lib/test_lib_spec.ts
@@ -21,7 +21,7 @@ class TestObj {
   someComplexFunc(a) { return a; }
 }
 
-@proxy()
+@proxy
 @IMPLEMENTS(TestObj)
 class SpyTestObj extends SpyObject {
   constructor() { super(TestObj); }

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ export function main() {`
`117`	`117`	`});`
`118`	`118`	`}`
`119`	`119`
`120`		`-@proxy()`
	`120`	`+@proxy`
`121`	`121`	`@IMPLEMENTS(ChangeDetectorRef)`
`122`	`122`	`class SpyChangeDetectorRef extends SpyObject {`
`123`	`123`	`constructor() { super(ChangeDetectorRef); }`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ export function main() {`
`119`	`119`	`});`
`120`	`120`	`}`
`121`	`121`
`122`		`-@proxy()`
	`122`	`+@proxy`
`123`	`123`	`@IMPLEMENTS(ChangeDetectorRef)`
`124`	`124`	`class SpyChangeDetectorRef extends SpyObject {`
`125`	`125`	`constructor() { super(ChangeDetectorRef); }`
Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ function createRenderViewportElementBinder(nestedProtoView) {`
`199`	`199`	`return new renderApi.ElementBinder({nestedProtoView: nestedProtoView});`
`200`	`200`	`}`
`201`	`201`
`202`		`-@proxy()`
	`202`	`+@proxy`
`203`	`203`	`@IMPLEMENTS(ChangeDetection)`
`204`	`204`	`class ChangeDetectionSpy extends SpyObject {`
`205`	`205`	`constructor() { super(ChangeDetection); }`