fix(code size): do not rely on Uri in BrowserDomAdapter

yjbanov · yjbanov · commit 9dc1d6ae810c · 2015-09-14T22:51:53.000Z
Closes #4182
diff --git a/modules/angular2/src/core/dom/browser_adapter.dart b/modules/angular2/src/core/dom/browser_adapter.dart
@@ -426,13 +426,12 @@ class BrowserDomAdapter extends GenericBrowserDomAdapter {
     return window.location;
   }
 
-  getBaseHref() {
+  String getBaseHref() {
     var href = getBaseElementHref();
     if (href == null) {
       return null;
     }
-    var baseUri = Uri.parse(href);
-    return baseUri.path[0] == '/' ? baseUri.path : ('/' + baseUri.path);
+    return _relativePath(href);
   }
 
   resetBaseElement() {
@@ -487,3 +486,14 @@ String getBaseElementHref() {
   }
   return baseElement.getAttribute('href');
 }
+
+// based on urlUtils.js in AngularJS 1
+AnchorElement _urlParsingNode = null;
+String _relativePath(String url) {
+  if (_urlParsingNode == null) {
+    _urlParsingNode = new AnchorElement();
+  }
+  _urlParsingNode.href = url;
+  var pathname = _urlParsingNode.pathname;
+  return (pathname[0] == '/') ? pathname : '/${pathname}';
+}

Original file line number	Diff line number	Diff line change
`@@ -426,13 +426,12 @@ class BrowserDomAdapter extends GenericBrowserDomAdapter {`
`426`	`426`	`return window.location;`
`427`	`427`	`}`
`428`	`428`
`429`		`- getBaseHref() {`
	`429`	`+ String getBaseHref() {`
`430`	`430`	`var href = getBaseElementHref();`
`431`	`431`	`if (href == null) {`
`432`	`432`	`return null;`
`433`	`433`	`}`
`434`		`- var baseUri = Uri.parse(href);`
`435`		`- return baseUri.path[0] == '/' ? baseUri.path : ('/' + baseUri.path);`
	`434`	`+ return _relativePath(href);`
`436`	`435`	`}`
`437`	`436`
`438`	`437`	`resetBaseElement() {`
`@@ -487,3 +486,14 @@ String getBaseElementHref() {`
`487`	`486`	`}`
`488`	`487`	`return baseElement.getAttribute('href');`
`489`	`488`	`}`
	`489`	`+`
	`490`	`+// based on urlUtils.js in AngularJS 1`
	`491`	`+AnchorElement _urlParsingNode = null;`
	`492`	`+String _relativePath(String url) {`
	`493`	`+ if (_urlParsingNode == null) {`
	`494`	`+ _urlParsingNode = new AnchorElement();`
	`495`	`+ }`
	`496`	`+ _urlParsingNode.href = url;`
	`497`	`+ var pathname = _urlParsingNode.pathname;`
	`498`	`+ return (pathname[0] == '/') ? pathname : '/${pathname}';`
	`499`	`+}`