X Tutup
Skip to content

Commit 894af28

Browse files
committed
fix(typings): include static members
Fixes #3175 Closes #3780
1 parent bf4b75e commit 894af28

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

docs/typescript-definition-package/templates/type-definition.template.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
{%- macro memberInfo(member) -%}
1212
{$ commentBlock(member, 5) $}
13-
{$ member.name $}{% if member.optional %}?{% endif -%}
13+
{% if member.isStatic -%}static {% endif -%}{$ member.name $}{% if member.optional %}?{% endif -%}
1414
{% if member.typeParameters %}<{% for typeParam in member.typeParameters %}{$ typeParam $}{% if not loop.last %}, {% endif %}{% endfor %}>{% endif -%}
1515
{%- if member.parameters -%}({% for param in member.parameters %}{$ param $}{% if not loop.last %}, {% endif %}{% endfor %}){%- endif -%}
1616
{%- if member.returnType -%}
@@ -58,6 +58,9 @@
5858
{%- if export.callMember %}
5959
{$ memberInfo(export.callMember) $}
6060
{% endif -%}
61+
{%- for static in export.statics %}
62+
{$ memberInfo(static) $}
63+
{%- endfor -%}
6164
{%- for member in export.members %}
6265
{$ memberInfo(member) $}
6366
{%- endfor %}

docs/typescript-package/processors/readTypeScriptModules.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ module.exports = function readTypeScriptModules(tsParser, modules, getFileInfo,
6464
log.debug('>>>> EXPORT: ' + exportDoc.name + ' (' + exportDoc.docType + ') from ' + moduleDoc.id);
6565

6666
exportDoc.members = [];
67+
exportDoc.statics = [];
6768

6869
// Generate docs for each of the export's members
6970
if (resolvedExport.flags & ts.SymbolFlags.HasMembers) {
@@ -102,6 +103,16 @@ module.exports = function readTypeScriptModules(tsParser, modules, getFileInfo,
102103
docs.push(memberDoc);
103104
exportDoc.members.push(memberDoc);
104105
}
106+
} else if (resolvedExport.flags & ts.SymbolFlags.HasExports) {
107+
for (var exported in resolvedExport.exports) {
108+
if (exported === 'prototype') continue;
109+
if (hidePrivateMembers && exported.charAt(0) === '_') continue;
110+
var memberSymbol = resolvedExport.exports[exported];
111+
var memberDoc = createMemberDoc(memberSymbol, exportDoc, basePath, parseInfo.typeChecker);
112+
memberDoc.isStatic = true;
113+
docs.push(memberDoc);
114+
exportDoc.statics.push(memberDoc);
115+
}
105116
}
106117

107118
if (sortClassMembers) {

modules/angular2/src/di/key.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ export {TypeLiteral} from './type_literal';
1616
* injector to index in arrays rather than looking up items in maps.
1717
*/
1818
export class Key {
19-
/**
20-
* @private
21-
*/
2219
constructor(public token: Object, public id: number) {
2320
if (isBlank(token)) {
2421
throw new BaseException('Token must be defined!');

0 commit comments

Comments
 (0)
X Tutup