fix(dart/transform): Remove malfunctioning zone error handler

Tim Blasi · Tim Blasi · commit 68a581a04ce4 · 2015-07-30T00:07:19.000Z
Remove `onError` zone callback which is consuming exceptions thrown by the `Transformer`s and can cause `pub` to become unresponsive. Closes #3368
diff --git a/modules/angular2/src/transform/bind_generator/transformer.dart b/modules/angular2/src/transform/bind_generator/transformer.dart
@@ -32,6 +32,6 @@ class BindGenerator extends Transformer {
       var transformedCode = await createNgSettersAndGetters(reader, id);
       transform.addOutput(new Asset.fromString(
           id, formatter.format(transformedCode, uri: id.path)));
-    }, errorMessage: 'Creating ng setters/getters failed.');
+    });
   }
 }
diff --git a/modules/angular2/src/transform/common/logging.dart b/modules/angular2/src/transform/common/logging.dart
@@ -11,20 +11,11 @@ typedef _SimpleCallback();
 final _key = #loggingZonedLoggerKey;
 
 /// Executes {@link fn} inside a new {@link Zone} with its own logger.
-dynamic initZoned(Transform t, _SimpleCallback fn, {String errorMessage: ''}) =>
-    setZoned(new BuildLogger(t), fn, errorMessage: errorMessage);
+dynamic initZoned(Transform t, _SimpleCallback fn) =>
+    setZoned(new BuildLogger(t), fn);
 
-dynamic setZoned(BuildLogger logger, _SimpleCallback fn,
-    {String errorMessage}) {
-  var onError;
-  if (errorMessage != null) {
-    onError = (e, stackTrace) {
-      logger.error('$errorMessage\n'
-          'Exception: $e\n'
-          'Stack Trace: $stackTrace');
-    };
-  }
-  return runZoned(fn, zoneValues: {_key: logger}, onError: onError);
+dynamic setZoned(BuildLogger logger, _SimpleCallback fn) {
+  return runZoned(fn, zoneValues: {_key: logger});
 }
 
 /// The logger for the current {@link Zone}.
diff --git a/modules/angular2/src/transform/deferred_rewriter/transformer.dart b/modules/angular2/src/transform/deferred_rewriter/transformer.dart
@@ -32,7 +32,7 @@ class DeferredRewriter extends Transformer {
         transform.addOutput(
             new Asset.fromString(transform.primaryInput.id, transformedCode));
       }
-    }, errorMessage: 'Rewritting deferred libraries failed.');
+    });
   }
 }
 
diff --git a/modules/angular2/src/transform/directive_linker/transformer.dart b/modules/angular2/src/transform/directive_linker/transformer.dart
@@ -31,7 +31,7 @@ class DirectiveLinker extends Transformer {
         var formattedCode = formatter.format(transformedCode, uri: assetPath);
         transform.addOutput(new Asset.fromString(assetId, formattedCode));
       }
-    }, errorMessage: 'Linking ng directives failed.');
+    });
   }
 }
 
@@ -50,6 +50,6 @@ class EmptyNgDepsRemover extends Transformer {
       if (!(await isNecessary(reader, transform.primaryInput.id))) {
         transform.consumePrimary();
       }
-    }, errorMessage: 'Removing unnecessary ng deps failed.');
+    });
   }
 }
diff --git a/modules/angular2/src/transform/directive_metadata_extractor/transformer.dart b/modules/angular2/src/transform/directive_metadata_extractor/transformer.dart
@@ -33,7 +33,7 @@ class DirectiveMetadataExtractor extends Transformer {
         transform.addOutput(new Asset.fromString(
             _outputAssetId(fromAssetId), _encoder.convert(ngMeta.toJson())));
       }
-    }, errorMessage: 'Extracting ng metadata failed.');
+    });
   }
 }
 
diff --git a/modules/angular2/src/transform/directive_processor/transformer.dart b/modules/angular2/src/transform/directive_processor/transformer.dart
@@ -53,6 +53,6 @@ class DirectiveProcessor extends Transformer {
         transform.addOutput(new Asset.fromString(ngAliasesId,
             new JsonEncoder.withIndent("  ").convert(ngMeta.toJson())));
       }
-    }, errorMessage: 'Processing ng directives failed.');
+    });
   }
 }
diff --git a/modules/angular2/src/transform/reflection_remover/transformer.dart b/modules/angular2/src/transform/reflection_remover/transformer.dart
@@ -52,6 +52,6 @@ class ReflectionRemover extends Transformer {
           mirrorMode: mirrorMode, writeStaticInit: writeStaticInit);
       transform.addOutput(
           new Asset.fromString(transform.primaryInput.id, transformedCode));
-    }, errorMessage: 'Removing reflection failed.');
+    });
   }
 }
diff --git a/modules/angular2/src/transform/template_compiler/generator.dart b/modules/angular2/src/transform/template_compiler/generator.dart
@@ -35,7 +35,8 @@ Future<String> processTemplates(AssetReader reader, AssetId entryPoint,
     {bool generateRegistrations: true,
     bool generateChangeDetectors: true}) async {
   var viewDefResults = await createViewDefinitions(reader, entryPoint);
-  var extractor = new _TemplateExtractor(new DomElementSchemaRegistry(), new XhrImpl(reader, entryPoint));
+  var extractor = new _TemplateExtractor(
+      new DomElementSchemaRegistry(), new XhrImpl(reader, entryPoint));
 
   var registrations = new reg.Codegen();
   var changeDetectorClasses = new change.Codegen();
@@ -112,9 +113,11 @@ class _TemplateExtractor {
 
     var pipeline = new CompilePipeline(_factory.createSteps(viewDef));
 
-    var compileElements =
-        pipeline.processElements(DOM.createTemplate(templateAndStyles.template), ViewType.COMPONENT, viewDef);
-    var protoViewDto = compileElements[0].inheritedProtoView.build(_schemaRegistry);
+    var compileElements = pipeline.processElements(
+        DOM.createTemplate(templateAndStyles.template), ViewType.COMPONENT,
+        viewDef);
+    var protoViewDto =
+        compileElements[0].inheritedProtoView.build(_schemaRegistry);
 
     reflector.reflectionCapabilities = savedReflectionCapabilities;
 
diff --git a/modules/angular2/src/transform/template_compiler/transformer.dart b/modules/angular2/src/transform/template_compiler/transformer.dart
@@ -35,6 +35,6 @@ class TemplateCompiler extends Transformer {
       var transformedCode = formatter.format(await processTemplates(reader, id,
           generateChangeDetectors: options.generateChangeDetectors));
       transform.addOutput(new Asset.fromString(id, transformedCode));
-    }, errorMessage: 'Parsing ng templates failed.');
+    });
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,6 @@ class BindGenerator extends Transformer {`
`32`	`32`	`var transformedCode = await createNgSettersAndGetters(reader, id);`
`33`	`33`	`transform.addOutput(new Asset.fromString(`
`34`	`34`	`id, formatter.format(transformedCode, uri: id.path)));`
`35`		`- }, errorMessage: 'Creating ng setters/getters failed.');`
	`35`	`+ });`
`36`	`36`	`}`
`37`	`37`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ class DeferredRewriter extends Transformer {`
`32`	`32`	`transform.addOutput(`
`33`	`33`	`new Asset.fromString(transform.primaryInput.id, transformedCode));`
`34`	`34`	`}`
`35`		`- }, errorMessage: 'Rewritting deferred libraries failed.');`
	`35`	`+ });`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class DirectiveLinker extends Transformer {`
`31`	`31`	`var formattedCode = formatter.format(transformedCode, uri: assetPath);`
`32`	`32`	`transform.addOutput(new Asset.fromString(assetId, formattedCode));`
`33`	`33`	`}`
`34`		`- }, errorMessage: 'Linking ng directives failed.');`
	`34`	`+ });`
`35`	`35`	`}`
`36`	`36`	`}`
`37`	`37`
`@@ -50,6 +50,6 @@ class EmptyNgDepsRemover extends Transformer {`
`50`	`50`	`if (!(await isNecessary(reader, transform.primaryInput.id))) {`
`51`	`51`	`transform.consumePrimary();`
`52`	`52`	`}`
`53`		`- }, errorMessage: 'Removing unnecessary ng deps failed.');`
	`53`	`+ });`
`54`	`54`	`}`
`55`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ class DirectiveMetadataExtractor extends Transformer {`
`33`	`33`	`transform.addOutput(new Asset.fromString(`
`34`	`34`	`_outputAssetId(fromAssetId), _encoder.convert(ngMeta.toJson())));`
`35`	`35`	`}`
`36`		`- }, errorMessage: 'Extracting ng metadata failed.');`
	`36`	`+ });`
`37`	`37`	`}`
`38`	`38`	`}`
`39`	`39`
Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,6 @@ class DirectiveProcessor extends Transformer {`
`53`	`53`	`transform.addOutput(new Asset.fromString(ngAliasesId,`
`54`	`54`	`new JsonEncoder.withIndent(" ").convert(ngMeta.toJson())));`
`55`	`55`	`}`
`56`		`- }, errorMessage: 'Processing ng directives failed.');`
	`56`	`+ });`
`57`	`57`	`}`
`58`	`58`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,6 @@ class ReflectionRemover extends Transformer {`
`52`	`52`	`mirrorMode: mirrorMode, writeStaticInit: writeStaticInit);`
`53`	`53`	`transform.addOutput(`
`54`	`54`	`new Asset.fromString(transform.primaryInput.id, transformedCode));`
`55`		`- }, errorMessage: 'Removing reflection failed.');`
	`55`	`+ });`
`56`	`56`	`}`
`57`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,6 @@ class TemplateCompiler extends Transformer {`
`35`	`35`	`var transformedCode = formatter.format(await processTemplates(reader, id,`
`36`	`36`	`generateChangeDetectors: options.generateChangeDetectors));`
`37`	`37`	`transform.addOutput(new Asset.fromString(id, transformedCode));`
`38`		`- }, errorMessage: 'Parsing ng templates failed.');`
	`38`	`+ });`
`39`	`39`	`}`
`40`	`40`	`}`