fix(core): fix type error in setElementProperty

DrMarcII · tbosch · commit 448264be39c4 · 2015-07-27T16:05:10.000-07:00
Convert propertyValue to string when calling setElementAttribute. Closes #3279
diff --git a/modules/angular2/src/render/dom/dom_renderer.ts b/modules/angular2/src/render/dom/dom_renderer.ts
@@ -147,7 +147,7 @@ export class DomRenderer extends Renderer {
     // Reflect the property value as an attribute value with ng-reflect- prefix.
     if (this._reflectPropertiesAsAttributes) {
       this.setElementAttribute(location, `${REFLECT_PREFIX}${camelCaseToDashCase(propertyName)}`,
-                               propertyValue);
+                               `${propertyValue}`);
     }
   }
 
diff --git a/modules/angular2/test/render/dom/dom_renderer_integration_spec.ts b/modules/angular2/test/render/dom/dom_renderer_integration_spec.ts
@@ -146,6 +146,26 @@ export function main() {
                  async.done();
                });
          }));
+
+      it('should reflect non-string property values as attributes if flag is set',
+         inject([AsyncTestCompleter, DomTestbed], (async, tb) => {
+           tb.compileAndMerge(someComponent,
+                              [
+                                new ViewDefinition({
+                                  componentId: 'someComponent',
+                                  template: '<input [title]="y">',
+                                  directives: []
+                                })
+                              ])
+               .then((protoViewMergeMappings) => {
+                 var rootView = tb.createView(protoViewMergeMappings);
+                 var el = DOM.childNodes(rootView.hostElement)[0];
+                 tb.renderer.setElementProperty(elRef(rootView.viewRef, 1), 'maxLength', 20);
+                 expect(DOM.getAttribute(<HTMLInputElement>el, 'ng-reflect-max-length'))
+                     .toEqual('20');
+                 async.done();
+               });
+         }));
     });
 
     if (DOM.supportsDOMEvents()) {

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ export class DomRenderer extends Renderer {`
`147`	`147`	`// Reflect the property value as an attribute value with ng-reflect- prefix.`
`148`	`148`	`if (this._reflectPropertiesAsAttributes) {`
`149`	`149`	this.setElementAttribute(location, `${REFLECT_PREFIX}${camelCaseToDashCase(propertyName)}`,
`150`		`- propertyValue);`
	`150`	+ `${propertyValue}`);
`151`	`151`	`}`
`152`	`152`	`}`
`153`	`153`