fix: remove deprecated zone API usage in testability

yjbanov · yjbanov · commit 3593d8580739 · 2015-11-07T00:13:29.000Z
Closes #5084
diff --git a/modules/angular2/src/core/testability/testability.ts b/modules/angular2/src/core/testability/testability.ts
@@ -4,7 +4,7 @@ import {Map, MapWrapper, ListWrapper} from 'angular2/src/core/facade/collection'
 import {CONST, CONST_EXPR} from 'angular2/src/core/facade/lang';
 import {BaseException, WrappedException} from 'angular2/src/core/facade/exceptions';
 import {NgZone} from '../zone/ng_zone';
-import {PromiseWrapper} from 'angular2/src/core/facade/async';
+import {PromiseWrapper, ObservableWrapper} from 'angular2/src/core/facade/async';
 
 
 /**
@@ -24,11 +24,17 @@ export class Testability {
 
   /** @internal */
   _watchAngularEvents(_ngZone: NgZone): void {
-    _ngZone.overrideOnTurnStart(() => { this._isAngularEventPending = true; });
-    _ngZone.overrideOnEventDone(() => {
-      this._isAngularEventPending = false;
-      this._runCallbacksIfReady();
-    }, true);
+    ObservableWrapper.subscribe(_ngZone.onTurnStart,
+                                (_) => { this._isAngularEventPending = true; });
+
+    _ngZone.runOutsideAngular(() => {
+      ObservableWrapper.subscribe(_ngZone.onEventDone, (_) => {
+        if (!_ngZone.hasPendingTimers) {
+          this._isAngularEventPending = false;
+          this._runCallbacksIfReady();
+        }
+      });
+    });
   }
 
   increasePendingRequestCount(): number {
diff --git a/modules/angular2/test/core/testability/testability_spec.ts b/modules/angular2/test/core/testability/testability_spec.ts
@@ -14,30 +14,29 @@ import {
 import {Testability} from 'angular2/src/core/testability/testability';
 import {NgZone} from 'angular2/src/core/zone/ng_zone';
 import {normalizeBlank} from 'angular2/src/core/facade/lang';
-import {PromiseWrapper} from 'angular2/src/core/facade/async';
+import {PromiseWrapper, EventEmitter, ObservableWrapper} from 'angular2/src/core/facade/async';
 
 // Schedules a microtasks (using a resolved promise .then())
 function microTask(fn: Function): void {
   PromiseWrapper.resolve(null).then((_) => { fn(); });
 }
 
 class MockNgZone extends NgZone {
-  _onTurnStart: () => void;
-  _onEventDone: () => void;
+  _onTurnStartStream: EventEmitter<any>;
+  get onTurnStart() { return this._onTurnStartStream; }
 
-  constructor() { super({enableLongStackTrace: false}); }
+  _onEventDoneStream: EventEmitter<any>;
+  get onEventDone() { return this._onEventDoneStream; }
 
-  start(): void { this._onTurnStart(); }
-
-  finish(): void { this._onEventDone(); }
-
-  overrideOnTurnStart(onTurnStartFn: Function): void {
-    this._onTurnStart = normalizeBlank(onTurnStartFn);
+  constructor() {
+    super({enableLongStackTrace: false});
+    this._onTurnStartStream = new EventEmitter(false);
+    this._onEventDoneStream = new EventEmitter(false);
   }
 
-  overrideOnEventDone(onEventDoneFn: Function, waitForAsync: boolean = false): void {
-    this._onEventDone = normalizeBlank(onEventDoneFn);
-  }
+  start(): void { ObservableWrapper.callNext(this._onTurnStartStream, null); }
+
+  finish(): void { ObservableWrapper.callNext(this._onEventDoneStream, null); }
 }
 
 export function main() {
