fix(transformer): Fix generation of annotations argument when registering functions.

jakemac53 · jakemac53 · commit 2faa89852b7e · 2015-07-28T15:26:33.000-07:00
diff --git a/modules/angular2/src/transform/directive_processor/rewriter.dart b/modules/angular2/src/transform/directive_processor/rewriter.dart
@@ -297,9 +297,9 @@ class CreateNgDepsVisitor extends Object with SimpleAstVisitor<Object> {
     _maybeWriteReflector();
     writer.print('..registerFunction(');
     node.name.accept(this);
-    writer.print(', new ${_REF_PREFIX}.ReflectionInfo(');
+    writer.print(', new ${_REF_PREFIX}.ReflectionInfo(const [');
     node.metadata.accept(_metaVisitor);
-    writer.print(', const [');
+    writer.print('], const [');
     node.functionExpression.parameters.accept(_paramsVisitor);
     writer.print(']))');
     return null;
diff --git a/modules/angular2/test/transform/directive_processor/absolute_url_expression_files/expected/hello.ng_deps.dart b/modules/angular2/test/transform/directive_processor/absolute_url_expression_files/expected/hello.ng_deps.dart
@@ -17,5 +17,7 @@ void initReflector() {
           template: r'''{{greeting}}''',
           templateUrl: r'package:other_package/template.html',
           styles: const [r'''.greeting { .color: blue; }''',])
-    ], const [], () => new HelloCmp()));
+    ], const [], () => new HelloCmp()))
+    ..registerFunction(
+        hello, new _ngRef.ReflectionInfo(const [const Injectable()], const []));
 }
diff --git a/modules/angular2/test/transform/directive_processor/absolute_url_expression_files/hello.dart b/modules/angular2/test/transform/directive_processor/absolute_url_expression_files/hello.dart
@@ -8,3 +8,6 @@ import 'package:angular2/angular2.dart'
     templateUrl: 'package:other_package/template.html',
     styleUrls: const ['package:other_package/template.css'])
 class HelloCmp {}
+
+@Injectable()
+hello() {}
diff --git a/modules/angular2/test/transform/directive_processor/static_function_files/expected/hello.ng_deps.dart b/modules/angular2/test/transform/directive_processor/static_function_files/expected/hello.ng_deps.dart
@@ -11,7 +11,7 @@ void initReflector() {
   _visited = true;
   _ngRef.reflector
     ..registerFunction(getMessage, new _ngRef.ReflectionInfo(
-        const Injectable(), const [const [const Inject(Message)]]))
+        const [const Injectable()], const [const [const Inject(Message)]]))
     ..registerType(Message, new _ngRef.ReflectionInfo(
         const [const Injectable()], const [], () => new Message()));
 }

Original file line number	Diff line number	Diff line change
`@@ -17,5 +17,7 @@ void initReflector() {`
`17`	`17`	`template: r'''{{greeting}}''',`
`18`	`18`	`templateUrl: r'package:other_package/template.html',`
`19`	`19`	`styles: const [r'''.greeting { .color: blue; }''',])`
`20`		`- ], const [], () => new HelloCmp()));`
	`20`	`+ ], const [], () => new HelloCmp()))`
	`21`	`+ ..registerFunction(`
	`22`	`+ hello, new _ngRef.ReflectionInfo(const [const Injectable()], const []));`
`21`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ void initReflector() {`
`11`	`11`	`_visited = true;`
`12`	`12`	`_ngRef.reflector`
`13`	`13`	`..registerFunction(getMessage, new _ngRef.ReflectionInfo(`
`14`		`- const Injectable(), const [const [const Inject(Message)]]))`
	`14`	`+ const [const Injectable()], const [const [const Inject(Message)]]))`
`15`	`15`	`..registerType(Message, new _ngRef.ReflectionInfo(`
`16`	`16`	`const [const Injectable()], const [], () => new Message()));`
`17`	`17`	`}`