fix(dart/reflection): Fix NoReflectionCapabilities interface

Tim Blasi · kegluneq · commit 0a3a17ff1061 · 2015-12-03T22:11:26.000Z
Make `NoReflectionCapabilities` conform to the `PlatformReflectionCapbilities` api, which prevents some confusing error messages. Closes #5559 Closes #5578
diff --git a/modules/angular2/src/core/reflection/reflection.dart b/modules/angular2/src/core/reflection/reflection.dart
@@ -7,45 +7,53 @@ import 'platform_reflection_capabilities.dart';
 import 'package:angular2/src/facade/lang.dart';
 
 class NoReflectionCapabilities implements PlatformReflectionCapabilities {
+  @override
   bool isReflectionEnabled() {
     return false;
   }
 
+  @override
   Function factory(Type type) {
     throw "Cannot find reflection information on ${stringify(type)}";
   }
 
+  @override
   List interfaces(Type type) {
     throw "Cannot find reflection information on ${stringify(type)}";
   }
 
-  List parameters(Type type) {
+  @override
+  List parameters(dynamic type) {
     throw "Cannot find reflection information on ${stringify(type)}";
   }
 
-  List annotations(Type type) {
+  @override
+  List annotations(dynamic type) {
     throw "Cannot find reflection information on ${stringify(type)}";
   }
 
-  Map propMetadata(Type type) {
+  @override
+  Map propMetadata(dynamic type) {
     throw "Cannot find reflection information on ${stringify(type)}";
   }
 
+  @override
   GetterFn getter(String name) {
     throw "Cannot find getter ${name}";
   }
 
+  @override
   SetterFn setter(String name) {
     throw "Cannot find setter ${name}";
   }
 
+  @override
   MethodFn method(String name) {
     throw "Cannot find method ${name}";
   }
 
+  @override
   String importUri(Type type) => './';
-
-  String moduleId(Type type) => './';
 }
 
 final Reflector reflector = new Reflector(new NoReflectionCapabilities());
diff --git a/modules/angular2/test/public_api_spec.ts b/modules/angular2/test/public_api_spec.ts
@@ -1449,7 +1449,6 @@ var NG_ALL = [
   "NoReflectionCapabilities.interfaces():dart",
   "NoReflectionCapabilities.isReflectionEnabled():dart",
   "NoReflectionCapabilities.method():dart",
-  "NoReflectionCapabilities.moduleId():dart",
   "NoReflectionCapabilities.parameters():dart",
   "NoReflectionCapabilities.propMetadata():dart",
   "NoReflectionCapabilities.setter():dart",

Original file line number	Diff line number	Diff line change
`@@ -7,45 +7,53 @@ import 'platform_reflection_capabilities.dart';`
`7`	`7`	`import 'package:angular2/src/facade/lang.dart';`
`8`	`8`
`9`	`9`	`class NoReflectionCapabilities implements PlatformReflectionCapabilities {`
	`10`	`+ @override`
`10`	`11`	`bool isReflectionEnabled() {`
`11`	`12`	`return false;`
`12`	`13`	`}`
`13`	`14`
	`15`	`+ @override`
`14`	`16`	`Function factory(Type type) {`
`15`	`17`	`throw "Cannot find reflection information on ${stringify(type)}";`
`16`	`18`	`}`
`17`	`19`
	`20`	`+ @override`
`18`	`21`	`List interfaces(Type type) {`
`19`	`22`	`throw "Cannot find reflection information on ${stringify(type)}";`
`20`	`23`	`}`
`21`	`24`
`22`		`- List parameters(Type type) {`
	`25`	`+ @override`
	`26`	`+ List parameters(dynamic type) {`
`23`	`27`	`throw "Cannot find reflection information on ${stringify(type)}";`
`24`	`28`	`}`
`25`	`29`
`26`		`- List annotations(Type type) {`
	`30`	`+ @override`
	`31`	`+ List annotations(dynamic type) {`
`27`	`32`	`throw "Cannot find reflection information on ${stringify(type)}";`
`28`	`33`	`}`
`29`	`34`
`30`		`- Map propMetadata(Type type) {`
	`35`	`+ @override`
	`36`	`+ Map propMetadata(dynamic type) {`
`31`	`37`	`throw "Cannot find reflection information on ${stringify(type)}";`
`32`	`38`	`}`
`33`	`39`
	`40`	`+ @override`
`34`	`41`	`GetterFn getter(String name) {`
`35`	`42`	`throw "Cannot find getter ${name}";`
`36`	`43`	`}`
`37`	`44`
	`45`	`+ @override`
`38`	`46`	`SetterFn setter(String name) {`
`39`	`47`	`throw "Cannot find setter ${name}";`
`40`	`48`	`}`
`41`	`49`
	`50`	`+ @override`
`42`	`51`	`MethodFn method(String name) {`
`43`	`52`	`throw "Cannot find method ${name}";`
`44`	`53`	`}`
`45`	`54`
	`55`	`+ @override`
`46`	`56`	`String importUri(Type type) => './';`
`47`		`-`
`48`		`- String moduleId(Type type) => './';`
`49`	`57`	`}`
`50`	`58`
`51`	`59`	`final Reflector reflector = new Reflector(new NoReflectionCapabilities());`