This repository was archived by the owner on Feb 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Support @FragmentArg on fields with type variable type #1445
Merged
yDelouis
merged 3 commits into
androidannotations:develop
from
WonderCsabo:1444_genericFragmentArg
Jun 14, 2015
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
...tional-test-1-5/src/main/java/org/androidannotations/test15/GenericFragmentArguments.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /** | ||
| * Copyright (C) 2010-2015 eBusiness Information, Excilys Group | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed To in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package org.androidannotations.test15; | ||
|
|
||
| import java.io.Serializable; | ||
|
|
||
| import org.androidannotations.annotations.EFragment; | ||
| import org.androidannotations.annotations.FragmentArg; | ||
|
|
||
| import android.accounts.Account; | ||
| import android.app.Fragment; | ||
|
|
||
| @EFragment | ||
| public class GenericFragmentArguments<S extends Serializable, P extends Account> extends Fragment { | ||
|
|
||
| @FragmentArg | ||
| S[] serializableArray; | ||
|
|
||
| @FragmentArg | ||
| P[] parcelableArray; | ||
|
|
||
| @FragmentArg | ||
| S serializable; | ||
|
|
||
| @FragmentArg | ||
| P parcelable; | ||
|
|
||
| } |
50 changes: 50 additions & 0 deletions
50
...ctional-test-1-5/src/test/java/org/androidannotations/test15/GenericFragmentArgsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /** | ||
| * Copyright (C) 2010-2015 eBusiness Information, Excilys Group | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed To in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package org.androidannotations.test15; | ||
|
|
||
| import static org.fest.assertions.api.Assertions.assertThat; | ||
|
|
||
| import java.io.Serializable; | ||
|
|
||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.robolectric.RobolectricTestRunner; | ||
| import org.robolectric.annotation.Config; | ||
|
|
||
| import android.accounts.Account; | ||
| import android.os.Bundle; | ||
|
|
||
| @Config(shadows = CustomShadowBundle.class) | ||
| @RunWith(RobolectricTestRunner.class) | ||
| public class GenericFragmentArgsTest { | ||
|
|
||
| private static final Account[] TEST_ARRAY = new Account[] { new Account("Android", "Annotations") }; | ||
|
|
||
| @Test | ||
| public void testParcelableArrayFragmentArgInjected() { | ||
| Bundle bundle = new Bundle(); | ||
| bundle.putParcelableArray("parcelableArray", TEST_ARRAY); | ||
|
|
||
| GenericFragmentArguments<Serializable, Account> fragment = new GenericFragmentArguments_<Serializable, Account>(); | ||
| fragment.setArguments(bundle); | ||
|
|
||
| assertThat(fragment.parcelableArray).isNull(); | ||
|
|
||
| fragment.onCreate(null); | ||
|
|
||
| assertThat(fragment.parcelableArray).isEqualTo(TEST_ARRAY); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yDelouis i wonder we may have to use
TypeKind.ERROR, too (or instead)?