Add convenience abstract super classes#1255
Add convenience abstract super classes#1255WonderCsabo merged 1 commit intoandroidannotations:developfrom
Conversation
|
looks good to me. |
|
I'm okay with that. I just wonder if there are some better package name for this two classes in the API. |
|
hm... maybe |
|
I do not think we should use |
|
hmm. yeah there might be some people that can't get the diffrence between i think wherever possible we (and every other project) should name packages by its meaning/use and not by "oh that could be confusing". </personal opinion> |
|
I not just meant the user confuses the two package, but he/she can think this package is somewhat related to the support lib. But otherwise i agree again. :) |
|
The proposal of @dodgex seems good to me. These classes doesn't exists in android support library so there is no chance someone get confused. |
@ReceiverAction and @ServiceAction require to add an empty implementation of the corresponding event handling method, since the method is abstract in the super class. For convenience, we provide AbstractBroadcastReceiver and AbstractIntentService classes, which implement the corresponding method, so the client does not have to.
WonderCsabo
force-pushed
the
1239_convenienceAbstractApiClasses
branch
from
3901e0e to
2caa8cf
Compare
…Classes Add convenience abstract super classes for @ReceiverAction and @ServiceAction
3 participants
Related to #1239.
@yDelouis @dodgex this is what you guys think of?