I just realized @ReceiverAction adds a never used context_ field. Why that is needed? If that is really unnecessary, can you add a new commit which removes that. I also think this is not good idea to save the context param anyway, since we can leak Context that way!

Otherwise, this PR looks good to me.

currently it seems required for stuff aditional injection. e.g. i have a @Perf that gets injected in init_() using the context_.

and when i see the generated code, i'm afraid that the Broadcast receiver is potentially a (VERY) big source of unexpected behaviour/bugs.

injection happens for each recived intent... let asume we have a @Bean that may have some state.

1. intent received
2. bean injected
3. @ReceiverAction called
   3.1) the method something with the bean
   3.2) method is still working...
4. another intent
5. [new] bean injected
6. @ReceiverAction called for new intent
7. BOOOOOOM the bean for the method call of the first intent is no longer available and the whole receiver is fckd up.

You are right... init_() is called in onReceive. My questions is: why? All injection should happen in onCreate, and onReceive should only handle the incoming Intents. Am is missing sg?

OK, i just realized. BroadcastReceiver do not have Context (nor onCreate...), so when @EReceiver was implemented they came up with this solution.

yeah. but i'm not sure if that is a good way.

BTW that is another issue. Can you open a new ticket to discuss that?

Back to my original question: generating context_ is not "lazy enough", can you fix that in this PR.

i have no idea how to do that the best way. currently i'm testing if it is possible to just pass the context to init_() for @EReceiver

added commit + rebased on develop

Thanks. The action and dataScheme local variables should also be generated lazily in onReceive.

Can you add a commit which lazily generates the action and dataScheme local variables in onReceive?

@WonderCsabo i think the action is required in all cases.

for dataScheme the only idea is by adding it right before the first ifwhere it is needed. so the code might look like

String action = ...
if(action.equals(action)) {
}
if(action2.equals(action)) {
}
String dataSchemes  = ..
if(action3.equals(action) && dataschemes.equal(scheme)) {
}

is that ok?

Action is not required if one not uses the @ReceiverAction annotation, but the local variables are still created. Check out the MyReceiver_ class in the test suite.

@dodgex can you address my comments?

oh. sure. i have overseen the last comment with about action without @ReceiverAction. is there another comment that i'm missing?

I think there is no other.

Thanks for this contribution. Can you update the wiki?

https://github.com/dodgex/androidannotations/wiki/Enhance-broadcastreceivers

Wiki merged, thanks!