GH-2: improve Stream and Optional API#3
Merged
alemazzo merged 1 commit intoalemazzo:mainfrom Jan 4, 2022
Merged
Conversation
sskorol
force-pushed
the
GH-2-improve-stream-and-optional-api
branch
2 times, most recently
from
341dfa3 to
f8a157e
Compare
- Added new orElse and orElseGet API to Optional class to follow the original Java style - Adjusted Stream's findFirst to support predicate to following the original Java style - Update py docs with newly added API - Added new ignorable items
sskorol
force-pushed
the
GH-2-improve-stream-and-optional-api
branch
from
f8a157e to
440df5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orElseandorElseGetAPI toOptionalclass to follow the original Java styleStream'sfindFirstAPI to support predicate to follow the original Java styleFixes #2
@alemazzo note that there were some DeepSource violations in the existing code. E.g. Stream's
ofAPI. As python doesn't welcome a Java-like overloading style, it has to be either refactored or ignored. I temporarily ignored this rule for the 49th line.