X Tutup
Skip to content

Fix thread leakage when override controller queue with withQueue #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuzp1996 merged 1 commit into from
Oct 17, 2024
Merged

Fix thread leakage when override controller queue with withQueue #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions .build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
apiVersion: builds.katanomi.dev/v1alpha1
kind: Build
spec:
workspaces:
- description: |
This workspace is shared among all the pipeline tasks to read/write common resources
name: source
- name: cache
tasks:
- name: maven
timeout: 30m
retries: 0
taskRef:
resolver: katanomi.hub
params:
- name: kind
value: task
- name: name
value: maven
workspaces:
- name: source
workspace: source
- name: cache
workspace: cache
when: []
params:
- name: command
value: |
mvn versions:set -DnewVersion=11.0.0-alauda-$(build.git.lastCommit.shortID); mvn clean deploy -DskipTests
- name: dependencies-repositories
value:
- https://build-nexus.alauda.cn/repository/alauda-maven/
- name: deploy-repository
value: https://build-nexus.alauda.cn/repository/alauda-maven/
git:
options:
depth: 1
timeout: 10m
retries: 0
resources:
limits:
cpu: 200m
memory: 200Mi
requests:
cpu: 200m
memory: 200Mi
runTemplate:
spec:
workspaces:
- name: cache
persistentVolumeClaim:
claimName: build-cache
subPath: maven
taskRunSpecs:
- pipelineTaskName: maven
stepOverrides:
- name: prepare
resources:
requests:
cpu: 1333m
memory: 1365Mi
limits:
cpu: 4000m
memory: 4096Mi
- name: maven
resources:
requests:
cpu: 1333m
memory: 1365Mi
limits:
cpu: 4000m
memory: 4096Mi
- name: analysis
resources:
requests:
cpu: 1334m
memory: 1366Mi
limits:
cpu: 4000m
memory: 4096Mi
3 changes: 3 additions & 0 deletions .../main/java/io/kubernetes/client/extended/controller/builder/DefaultControllerBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ public DefaultControllerBuilder withName(String controllerName) {
* @return the controller builder
*/
public DefaultControllerBuilder withWorkQueue(RateLimitingQueue<Request> workQueue) {
if (this.workQueue != null && !this.workQueue.isShuttingDown()){
this.workQueue.shutDown();
}
this.workQueue = workQueue;
return this;
}
Expand Down
26 changes: 1 addition & 25 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
<module>client-java-contrib/cert-manager</module>
<module>e2e</module>
<module>client-java-contrib/prometheus-operator</module>
<module>examples</module>
</modules>

<scm>
Expand Down Expand Up @@ -322,20 +321,7 @@

</dependencies>
</dependencyManagement>

<distributionManagement>
<snapshotRepository>
<id>ossrh</id>
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
<layout>default</layout>
</snapshotRepository>
<repository>
<id>ossrh</id>
<url>https://oss.sonatype.org/service/local/staging/deploy/maven2</url>
<layout>default</layout>
</repository>
</distributionManagement>


<build>
<pluginManagement>
<plugins>
Expand Down Expand Up @@ -433,16 +419,6 @@
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.sonatype.plugins</groupId>
<artifactId>nexus-staging-maven-plugin</artifactId>
<extensions>true</extensions>
<configuration>
<serverId>ossrh</serverId>
<nexusUrl>https://oss.sonatype.org/</nexusUrl>
<autoReleaseAfterClose>true</autoReleaseAfterClose>
</configuration>
</plugin>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
Expand Down
X Tutup