fix: Add missing tickValues prop type#1855
fix: Add missing tickValues prop type#1855f1multiviewer wants to merge 1 commit intoairbnb:masterfrom
tickValues prop type#1855Conversation
hshoff
left a comment
There was a problem hiding this comment.
Nice, an F1 app sending PRs during FP2. Needs a small change and we should be good to land this.
a87da03 to
90039a9
Compare
7ac4a6f to
8721baa
Compare
|
Okay, so I've found that the Currently though, I'm struggling to use the package locally, using |
This adds two field types, fields already available in `<BaseGrid>`, to the `CommonGridTProps` type.
8721baa to
61edd41
Compare
|
Any updates so far? @f1multiviewer Referring to the cd /packages/visx-demo
yarn
yarn devBecause i'm new to contributing this repo, i'll try once in then elaborate it to you later. UpdatesStruggling on building the module. 🥹 |
@f1multiviewer export type SharedAxisProps<Scale extends AxisScale> = CommonProps<Scale> & {
// ...
/** An array of values that determine the number and values of the ticks. Falls back to `scale.ticks()` or `.domain()`. */
tickValues?: ScaleInput<Scale>[];
// ...
};How're your thoughts? |
🐛 Bug Fix
Fixes an issue where the
tickValuesproperty wasn't properly being typed, even though it works when being passed.Related: #376