@williaster quick ping for workflow approval, thanks!

Thanks for the PR @nagiek 🙏 . My main concern with this approach is that two ways to pass data (to XYChart or to *Series) may cause confusion.

I just tried implementing the useComponentWillMount approach but the () => unregisterData(dataKeys) we currently return in useEffect for unmounting components is causing problems/I can't quite get it to work right. I'll keep tinkering a bit and think about whether there are any alternatives to your suggested approach.

No problem, I understand. I kept working on my version but I agree it’s a different technique.

What about splitting the existing useEffect call into two calls? One to useMemo containing registerData, and one to useEffect containing unregisterData?

Quick follow up, thank you!

Hello! I’m suffering the same issue over here. How is the progress looking, can I help out some how?

@nagiek Are you using this approach in production? I'd love to see SSR supported.

@williaster

My main concern with this approach is that two ways to pass data (to XYChart or to *Series) may cause confusion.

Would a separate component make sense? Similar to how there are separate Animated and not-Animated components, there could be a ServerXYChart and a ClientXYChart, which could be aliased as just XYChart for backward compatibility. This way the different components could take different approaches to loading the data, and any duplicated functionality could be de-duplicated behind the scenes.

Any updates on this? Doing what @mscottford said, creating a ServerXYChart, would fix the issues that you commented about @williaster? Are these still issues on the current react version?

Hey @hshoff, any inputs on this?