Remove numpy.int and numpy.float#152
Merged
ahmedfgad merged 1 commit intoahmedfgad:masterfrom Feb 14, 2023
Merged
Conversation
These aliases are deprecated in numpy, can be ignored, since it's the same as regular int or float
10 tasks
|
@ahmedfgad could you please consider this PR? I think it might be very good to get this in. |
|
@ahmedfgad This solves the problem of importing the library. Please consider accepting this PR asap. |
|
This library is broken without this PR. Maybe this project needs a new maintainer? |
|
+1 it would be great to have this fixed such that the newest version of numpy can be used |
ahmedfgad
approved these changes
Feb 14, 2023
Owner
|
Thanks everyone and apologize for the period of silence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These aliases are deprecated in numpy, can be ignored, since it's the same as regular int or float