An implementation of a new frequency mode, see issue #333#334
Draft
marler8997 wants to merge 1 commit intoaduros:mainfrom
Draft
An implementation of a new frequency mode, see issue #333#334marler8997 wants to merge 1 commit intoaduros:mainfrom
marler8997 wants to merge 1 commit intoaduros:mainfrom
Conversation
Contributor
|
Feels like we need a |
3deaf52 to
5321f17
Compare
aduros
added a commit
that referenced
this pull request
Apr 18, 2024
APU Note Mode (alternative version of #334)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An implementation of the "Audio Frequency Proposal" found here: #333
At this point the proposal has not been accepted, but I've implemented it here to demonstrate what it would take to support the proposal along with keeping the current mechanism (whole-number frequencies).
To summarize what this does, this redistributes the frequencies to be logarithmic so that a difference in values has the same harmonic affect regardless of the absolute value of the frequency. Adding 256 to the tone argument value increases the frequency by one "musical half step". The formula to convert a tone argument to a frequency is now given by:
Here's an example of how to use it: