Handle flow via imports and exports in Unsubtyping#8439
Open
Conversation
We previously upated Unsubtyping so that any subtype of the result of a JS-called function would keep its descriptor if that descriptor could configure a JS prototype. But configured prototypes can also become visible indirectly because they flow out of the module via imported or exported functions, globals, or tables. Handle these cases of values flowing in from or out to JS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously upated Unsubtyping so that any subtype of the result of a
JS-called function would keep its descriptor if that descriptor could
configure a JS prototype. But configured prototypes can also become
visible indirectly because they flow out of the module via imported or
exported functions, globals, or tables. Handle these cases of values
flowing in from or out to JS.