FIX: UI inconsistencies - Single helpbox for repetitive default settings mentions#2372
FIX: UI inconsistencies - Single helpbox for repetitive default settings mentions#2372josepmariapujol-unity wants to merge 10 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
The PR quality is great. I found a few minor issues regarding code structure and potential dead code.
- Moving shared footer logic to a non-generic base class can reduce metadata bloat.
- Using events instead of single callbacks prevents overwriting.
- Clean up unused parameters and potentially dead member variables.
🤖 Helpful? 👍/👎
| m_OnUseDefaultChanged = callback; | ||
| } | ||
|
|
||
| internal static void AddSharedDefaultSettingsFooter(VisualElement root, |
There was a problem hiding this comment.
The AddSharedDefaultSettingsFooter method is a static method defined within a nested class of the generic InputParameterEditor<TValue>. Since the logic for creating and refreshing the footer does not depend on the generic type parameter TValue, this results in redundant code generation and metadata for every distinct type of interaction or processor that uses it. Consider moving CustomOrDefaultSetting (and this helper method) to the non-generic InputParameterEditor base class to improve maintainability and reduce assembly size.
🤖 Helpful? 👍/👎
Packages/com.unity.inputsystem/InputSystem/Editor/InputParameterEditor.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/InputParameterEditor.cs
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/InputParameterEditor.cs
Outdated
Show resolved
Hide resolved
…the rest" This reverts commit 06136de.
|
/review |
|
/crc |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr |
| if (useDefaultChanged) | ||
| onUseDefaultChanged?.Invoke(); | ||
| EditorGUILayout.EndHorizontal(); |
There was a problem hiding this comment.
By removing the HelpBox and the "Open Input Settings" button from OnGUI(), this messaging is completely lost for IMGUI users.
Since AddSharedDefaultSettingsFooter is strictly for UIElements, any custom parameter editors or third-party code that still rely on OnGUI() (which the Input System still supports as a fallback) will no longer display the help text explaining what the default value is, nor provide the button to open the settings.
Have you considered adding a shared footer equivalent for IMGUI, or preserving the individual messaging here so that the IMGUI fallback retains feature parity?
🤖 Helpful? 👍/👎
Description
Previously, the interface displayed repetitive messages along with multiple links to the settings, which made the UI more cluttered and harder to read. This update replaces those repeated messages with a single
HelpBoxthat clearly explains the default behavior and provides the relevant guidance in one place.Changes
• Reduced UI clutter and improved readability.
• Kept the link to the relevant settings within the unified HelpBox.
Result
• Clearer and more maintainable UI messaging.
• A more consistent user experience with less duplicated information.
Before:

After:

https://jira.unity3d.com/browse/ISX-2340
Testing status & QA
Toggle and untoggle the buttons and check the names in the helpbox to make sure it works.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.