NEW: Extended action code generator to provide support for adding and removing multiple callback instances.#1593
Merged
jamesmcgill merged 11 commits intodevelopfrom Nov 8, 2022
Conversation
… removing multiple callback instances via generated code.
jimon
reviewed
Oct 11, 2022
| // Uninitialize existing interface. | ||
| writer.WriteLine($"if (m_Wrapper.m_{mapTypeName}CallbackInterface != null)"); | ||
| writer.BeginBlock(); | ||
| //writer.WriteLine($"m_Wrapper.m_{mapTypeName}CallbackInterface = instance;"); |
Collaborator
Author
There was a problem hiding this comment.
Thanks, this have been removed now
jimon
approved these changes
Oct 11, 2022
jamesmcgill
approved these changes
Oct 11, 2022
Collaborator
Author
|
@jimon @jamesmcgill Thanks for reviewing. I found that the explicit formatter of the code generator wasn't matching the the auto-formatter scripts so I updated the generator to match the auto-formatting. Hopefully this is ok now. |
ekcoh
added
the
feature
jamesmcgill
deleted the
improved-code-generator-support-for-multiple-callback-instances
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… removing multiple callback instances via generated code.
Description
Original user-contribution here from Ramobo: #889.
Changes made
Original contribution modified to preserve backwards compatible behavior for
SetCallbacksand adding tests for generated code to provide code coverage.Notes
Please write down any additional notes, remove the section if not applicable.
Checklist
Before review:
Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.