X Tutup
Skip to content

Fixed unexpected lua error from Object.GetOwnPropertyDescriptors nil #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 1 commit into from
Mar 2, 2021
Merged

Fixed unexpected lua error from Object.GetOwnPropertyDescriptors nil #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lualib/ObjectGetOwnPropertyDescriptors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
function __TS__ObjectGetOwnPropertyDescriptors(this: void, object: any): Record<any, PropertyDescriptor | undefined> {
const metatable = getmetatable(object);
if (!metatable) return {};
return rawget(metatable, "_descriptors");
return rawget(metatable, "_descriptors") || {};
}
24 changes: 24 additions & 0 deletions test/unit/builtins/object.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,3 +211,27 @@ describe("Object.getOwnPropertyDescriptors", () => {
`.expectToMatchJsResult();
});
});

describe("delete from object", () => {
test("delete from object", () => {
util.testFunction`
const obj = { foo: "bar", bar: "baz" };
delete obj["foo"];
return obj;
`
.setTsHeader("declare function setmetatable<T extends object>(this: void, table: T, metatable: any): T;")
.expectToEqual({ bar: "baz" });
});

// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/993
test("delete from object with metatable", () => {
util.testFunction`
const obj = { foo: "bar", bar: "baz" };
setmetatable(obj, {});
delete obj["foo"];
return obj;
`
.setTsHeader("declare function setmetatable<T extends object>(this: void, table: T, metatable: any): T;")
.expectToEqual({ bar: "baz" });
});
});
X Tutup