Merged
Conversation
lolleko
approved these changes
Feb 21, 2021
| ` | ||
| .setOptions(tableProjectOptions) | ||
| .expectToEqual(1); | ||
| }); |
Member
There was a problem hiding this comment.
Not sure why someone would do that, but could you add a test for new LuaTable().get/set("test"). Just to ensure that works and does not produce invalid Lua ({}["test"]).
| ); | ||
|
|
||
| export const invalidTableExtensionUse = createErrorDiagnosticFactory( | ||
| "This function must always be directly called and cannot be referred to." |
Member
There was a problem hiding this comment.
Suggested change
| "This function must always be directly called and cannot be referred to." | |
| "This function must be called directly and cannot be referred to." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next extension for #963
This adds a set of new extensions to replace functionality provided by
@luaTable.It adds
LuaTableGet&LuaTableSet(and method variants) to allow declaring functions which map tovalue = table[index]andtable[index] = value, similar to how operator overload mappings work.It also adds a
LuaTableinterface andLuaTableConstructorextension to allow tables to be created directly: