Fix export all bug and add NamespaceExport support#937
Merged
Perryvw merged 6 commits intoTypeScriptToLua:masterfrom Dec 14, 2020
Merged
Fix export all bug and add NamespaceExport support#937Perryvw merged 6 commits intoTypeScriptToLua:masterfrom
Perryvw merged 6 commits intoTypeScriptToLua:masterfrom
Conversation
hazzard993
force-pushed
the
export-all-fix
branch
from
990ec68 to
9dae80f
Compare
hazzard993
changed the title
Perryvw
reviewed
Dec 13, 2020
|
|
||
| const ifBody = lua.createBlock([leftAssignment]); | ||
|
|
||
| const ifStatement = lua.createIfStatement( |
Member
There was a problem hiding this comment.
Could you add a comment explaining what the purpose of this if statement is.
Contributor
Author
There was a problem hiding this comment.
Added some more comments to transformExportAll, I think it should be much easier to read now
| const declaration = lua.createVariableDeclarationStatement(tempModuleIdentifier, moduleRequire); | ||
| result.push(declaration); | ||
|
|
||
| if (node.exportClause && ts.isNamespaceExport(node.exportClause)) { |
Member
There was a problem hiding this comment.
Could you add a comment explaining in what case this if statement is needed and what this branch of this function does?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #927
Resolves #928