Add luaTarget: "universal"#873
Merged
Perryvw merged 7 commits intoTypeScriptToLua:masterfrom May 24, 2020
Merged
Conversation
Perryvw
reviewed
May 23, 2020
| case LuaTarget.Universal: | ||
| case LuaTarget.Lua51: | ||
| context.diagnostics.push(unsupportedForTarget(node, "Bitwise operations", LuaTarget.Lua51)); | ||
| context.diagnostics.push(unsupportedForTarget(node, "Bitwise operations", context.luaTarget)); |
Member
There was a problem hiding this comment.
For the other messages you left the version mentioned in the diagnostic to be 5.1 (which also makes sense). We should probably be consistent with this though.
test/unit/builtins/math.spec.ts
Outdated
|
|
||
| const expectMathAtan2: util.TapCallback = builder => expect(builder.getMainLuaCodeChunk()).toContain("math.atan2("); | ||
| const expectMathAtan: util.TapCallback = builder => expect(builder.getMainLuaCodeChunk()).toContain("math.atan("); | ||
| const expectTsMathAtan2: util.TapCallback = builder => |
Member
There was a problem hiding this comment.
Maybe it would be nicer to call this expectLualibMathAtan2.
Perryvw
reviewed
May 24, 2020
test/unit/spread.spec.ts
Outdated
| // TODO: Make some utils for testing other targets | ||
| const expectUnpack: util.TapCallback = builder => expect(builder.getMainLuaCodeChunk()).toMatch(/[^.]unpack\(/); | ||
| const expectTableUnpack: util.TapCallback = builder => expect(builder.getMainLuaCodeChunk()).toContain("table.unpack"); | ||
| const expectTsUnpack: util.TapCallback = builder => expect(builder.getMainLuaCodeChunk()).toContain("__TS__Unpack"); |
Member
There was a problem hiding this comment.
Since we changed expectTsMathAtan2 to expectLualibMathAtan2, I would suggest also changing this one to expectLualibUnpack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #749