Generator and iteration improvements#872
Merged
Perryvw merged 6 commits intoTypeScriptToLua:masterfrom May 23, 2020
Merged
Conversation
…ration-improvements
Perryvw
approved these changes
May 22, 2020
| @@ -0,0 +1,19 @@ | |||
| /** @noSelfInFile */ | |||
Member
There was a problem hiding this comment.
Do we still need these lualib declarations now we included lua-types as dependency?
Contributor
Author
There was a problem hiding this comment.
lua-types is used only in benchmark project, not in lualib. It should be possible to use it in the future, but it probably would need some code changes, since some things are declared differently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #601
Fixes #600
Fixes #871