Intermediate SpreadElements fix#832
Merged
Perryvw merged 23 commits intoTypeScriptToLua:masterfrom Mar 15, 2020
Merged
Conversation
ark120202
reviewed
Feb 27, 2020
Perryvw
reviewed
Feb 27, 2020
src/transformation/visitors/call.ts
Outdated
|
|
||
| // Only one spread element at the end? Will work as expected | ||
| const [firstExpression] = postSpreadExpressions; | ||
| if (postSpreadExpressions.length === 1 && ts.isSpreadElement(firstExpression)) { |
Member
There was a problem hiding this comment.
isn't ts.isSpreadElement(firstExpression) always true by definition of getExpressionsBeforeAndAfterFirstSpread?
Contributor
Author
There was a problem hiding this comment.
true, that can be refactored
ark120202
reviewed
Feb 29, 2020
Co-Authored-By: ark120202 <ark120202@gmail.com>
Co-Authored-By: ark120202 <ark120202@gmail.com>
Perryvw
approved these changes
Mar 8, 2020
test/unit/spread.spec.ts
Outdated
| `.expectToMatchJsResult(); | ||
| }); | ||
|
|
||
| test("of string literal mixed", () => { |
Contributor
Author
There was a problem hiding this comment.
Changed to just of string literal
ark120202
reviewed
Mar 8, 2020
Co-Authored-By: ark120202 <ark120202@gmail.com>
Co-Authored-By: ark120202 <ark120202@gmail.com>
Co-Authored-By: ark120202 <ark120202@gmail.com>
…escriptToLua into smarter-spreading
ark120202
approved these changes
Mar 15, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #696
Uses ArrayConcat only when necessary to replicate TS behavior