Generalize class accessors transform#774
Merged
Perryvw merged 11 commits intoTypeScriptToLua:masterfrom Mar 12, 2020
Merged
Conversation
Perryvw
reviewed
Jan 6, 2020
test/unit/printer/sourcemaps.spec.ts
Outdated
| { luaPattern: "setmetatable(Bar,", typeScriptPattern: "Foo {" }, | ||
| { luaPattern: "setmetatable(Bar.prototype,", typeScriptPattern: "Foo {" }, | ||
| { luaPattern: "__TS__ClassExtends(", typeScriptPattern: "extends" }, | ||
| { luaPattern: "Foo)", typeScriptPattern: "Foo {" }, |
Member
There was a problem hiding this comment.
This last pattern seems a bit strange to test. Could we instead test some other lua pattern we actually care about, otherwise just delete this. I doubt lua will ever throw an error on Foo)'s location anyway.
Contributor
Author
There was a problem hiding this comment.
I've changed it to a function call, which should be a more important mapping
Member
|
Can you add a 'Next release' section the changelog and add a point describing this PR? |
Perryvw
reviewed
Mar 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #725