Allow throwing arbitrary types and add builtin error classes by TheLartians · Pull Request #724 · TypeScriptToLua/TypeScriptToLua

TheLartians · 2019-09-24T13:47:59Z

This PR enables throwing custom error objects and adds the builtin error classes as defined by JavaScript. Also fixes a bug in LuaTransformer.transformClassExpression() where local class definitions had global scope.

Example

Arbitrary errors

try {
  throw {x: "Hello error object!"};
} catch (error) {
  console.log(error.x); // -> Hello error object!
}

Builtin errors

try {
  throw RangeError("message"); // or new RangeError("message")
} catch (error) {
  if (error instanceof Error) {
    console.log(error); // -> RangeError: message
    console.log(error.name); // -> RangeError
    console.log(error.message); // -> message
    console.log(error.stack); // prints stack trace from where the error was thrown
  }
}

Inheritance

class MyError extends Error{
  name: "MyError"
}

try {
  throw new MyError("message");
} catch (error) {
  // same error properties as builtin errors
}

src/lualib/Error.ts

test/unit/error.spec.ts

src/lualib/Error.ts

Co-Authored-By: ark120202 <ark120202@gmail.com>

src/LuaLib.ts

src/lualib/Error.ts

src/LuaTransformer.ts

src/lualib/Error.ts

ark120202 · 2019-09-25T23:46:28Z

Lazy getter would be nice, however unavailable here due to #725 as it would break subclassing Error.

I've been testing on Safari. In Chrome/V8 the stack does include the error name and message before the traceback. I prefer Error.stack to only contain the traceback, but we might just as well accept the V8 as ground truth here.

Actually, looks like Error#stack isn't part of a standard at all, so we aren't ought to follow any of existing implementations. But doing what Safari does there isn't good, since .stack is usually used to print the full error text in the same way you'd see it after throwing.

There is a stage 1 proposal (rendered) which I think we should follow. It defines stack as a getter with that logic: https://tc39.es/proposal-error-stacks/#sec-getstackstring.

TheLartians · 2019-09-26T10:14:01Z

There is a stage 1 proposal (rendered) which I think we should follow.

I agree, but for that to work we would need to use accessors, which don't work with subclassing at the moment. We can update the functionality as soon as #725 is fixed.

src/LuaTransformer.ts

src/lualib/Error.ts

test/unit/error.spec.ts

src/LuaTransformer.ts

test/unit/error.spec.ts

src/lualib/Error.ts

test/unit/error.spec.ts

Co-Authored-By: ark120202 <ark120202@gmail.com>

src/lualib/Error.ts

test/unit/error.spec.ts

Co-Authored-By: ark120202 <ark120202@gmail.com>

TheLartians · 2019-10-01T08:53:07Z

I've rolled back to supporting Error.toString() only for the built-in error types as more general support for derived types will be available once #728 gets resolved.

test/unit/error.spec.ts

ark120202 · 2019-10-01T11:37:34Z

test/unit/error.spec.ts

 });
+
+test.each([
+    `"error string"`,


Might be a bit cleaner to pass actual values there and convert them with util.valueToString

True, won't atm due to util.valueToString(undefined) = undefined (#733).

test/unit/error.spec.ts

TheLartians added 2 commits September 24, 2019 15:52

track Scope in transformClassExpression

5a19a37

allow throwing arbitrary types and add builtin error classes

46fdc43

TheLartians force-pushed the master branch from 58bba85 to 46fdc43 Compare September 24, 2019 13:52

allow subclassing Error

a0e3f14

ark120202 reviewed Sep 24, 2019

View reviewed changes

TheLartians and others added 4 commits September 25, 2019 00:48

Update test/unit/error.spec.ts

d70d3f9

Co-Authored-By: ark120202 <ark120202@gmail.com>

use custom traceback in errors

4f5734b

return full stack on fallback

e88392b

use builder API for tests

d30982f

TheLartians requested a review from ark120202 September 25, 2019 12:58

TheLartians force-pushed the master branch 3 times, most recently from 10c9bc9 to 39704ca Compare September 25, 2019 13:19

cleanup

771152d

TheLartians force-pushed the master branch from 39704ca to 771152d Compare September 25, 2019 13:20

ark120202 reviewed Sep 25, 2019

View reviewed changes

src/LuaLib.ts Outdated Show resolved Hide resolved

src/lualib/Error.ts Outdated Show resolved Hide resolved

src/LuaTransformer.ts Show resolved Hide resolved

src/lualib/Error.ts Outdated Show resolved Hide resolved

src/lualib/Error.ts Outdated Show resolved Hide resolved

TheLartians added 3 commits September 26, 2019 11:51

add error name to type and reduce dependencies

91363b9

test subclasses for stack

11b8610

test string representation of subclassed errors

cdb2754

fix throwing as function test

92b680d

Perryvw requested changes Sep 26, 2019

View reviewed changes

src/LuaTransformer.ts Outdated Show resolved Hide resolved

src/lualib/Error.ts Show resolved Hide resolved

src/lualib/Error.ts Outdated Show resolved Hide resolved

src/lualib/Error.ts Outdated Show resolved Hide resolved

test/unit/error.spec.ts Outdated Show resolved Hide resolved

TheLartians force-pushed the master branch from e8ea8f3 to c17b5b5 Compare September 26, 2019 15:48

style changes

99584de

TheLartians force-pushed the master branch from c17b5b5 to 99584de Compare September 26, 2019 15:52

Perryvw reviewed Sep 26, 2019

View reviewed changes

src/LuaTransformer.ts Show resolved Hide resolved

test/unit/error.spec.ts Show resolved Hide resolved

src/lualib/Error.ts Outdated Show resolved Hide resolved

TheLartians added 2 commits September 26, 2019 19:17

formatting

d1ca812

add sourceMapTraceback option to test

f0fab20

Perryvw reviewed Sep 26, 2019

View reviewed changes

test/unit/error.spec.ts Outdated Show resolved Hide resolved

TheLartians and others added 6 commits September 29, 2019 22:30

fix throwing strings and update tests

893cc7a

Update src/lualib/Error.ts

ffa9d6d

Co-Authored-By: ark120202 <ark120202@gmail.com>

test extending from error with custom toString()

613d118

update identifiers test for new exception handling

dd77294

use constructor assignment for message property

df05bb6

print stack for uncaught errors

cbd980d

ark120202 reviewed Sep 30, 2019

View reviewed changes

src/lualib/Error.ts Outdated Show resolved Hide resolved

ark120202 reviewed Sep 30, 2019

View reviewed changes

test/unit/error.spec.ts Outdated Show resolved Hide resolved

test/unit/error.spec.ts Outdated Show resolved Hide resolved

test/unit/error.spec.ts Outdated Show resolved Hide resolved

TheLartians mentioned this pull request Oct 1, 2019

Inheritance breaks toString() #728

Closed

TheLartians and others added 4 commits October 1, 2019 09:28

Update test/unit/error.spec.ts

52f15c6

Co-Authored-By: ark120202 <ark120202@gmail.com>

Update test/unit/error.spec.ts

ebf0c1c

Co-Authored-By: ark120202 <ark120202@gmail.com>

rollback toString() support

371c841

add more test cases

b9fdd40

formatting

a0b63e1

ark120202 reviewed Oct 1, 2019

View reviewed changes

set __tostring metamethod in constructor

6066a7e

TheLartians force-pushed the master branch from 1c2beb6 to 6066a7e Compare October 5, 2019 17:57

TheLartians added 2 commits October 9, 2019 12:26

update tests

5400f89

remove generic from ErrorType

817b4e7

ark120202 reviewed Oct 9, 2019

View reviewed changes

test/unit/error.spec.ts Outdated Show resolved Hide resolved

test/unit/error.spec.ts Show resolved Hide resolved

test/unit/error.spec.ts Outdated Show resolved Hide resolved

TheLartians added 2 commits October 9, 2019 12:50

add info string to tests

7b23ae3

style changes

d6d2855

ark120202 reviewed Oct 9, 2019

View reviewed changes

test/unit/error.spec.ts Outdated Show resolved Hide resolved

test/unit/error.spec.ts Outdated Show resolved Hide resolved

test/unit/error.spec.ts Outdated Show resolved Hide resolved

test/unit/error.spec.ts Outdated Show resolved Hide resolved

style changes

3dea2cc

ark120202 approved these changes Oct 9, 2019

View reviewed changes

Perryvw approved these changes Oct 9, 2019

View reviewed changes

Perryvw merged commit bf9f609 into TypeScriptToLua:master Oct 9, 2019

This was referenced Nov 24, 2019

Runtime crash if a class extends Error #533

Closed

Support custom exceptions #531

Closed

Uh oh!

Conversation

TheLartians commented Sep 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Example

Arbitrary errors

Builtin errors

Inheritance

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ark120202 commented Sep 25, 2019

Uh oh!

TheLartians commented Sep 26, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheLartians commented Oct 1, 2019

Uh oh!

Uh oh!

Uh oh!

ark120202 Oct 1, 2019

Choose a reason for hiding this comment

Uh oh!

TheLartians Oct 5, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TheLartians commented Sep 24, 2019 •

edited

Loading