fixed default binding pattern parameters#589
Merged
Conversation
Perryvw
reviewed
May 21, 2019
src/LuaTransformer.ts
Outdated
| )); | ||
| if (binding.initializer !== undefined) { | ||
| const declaration = this.transformParameterDefaultValueDeclaration(identifier, binding.initializer); | ||
| defaultValueDeclarations.splice(i, 0, declaration); |
Member
There was a problem hiding this comment.
I think this is is unnecessarily complex, it seems to me this is is a hack so you can keep the map at 1359. In this case it might be simpler to just replace that map with a for ... of or forEach and push the declaration plus an additional optional push for the value to some predefined list.
Collaborator
Author
There was a problem hiding this comment.
I won't deny it was a bit of a hack. I've refactored this into something a bit more sensible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #530