New functions - return values and context inference#304
Merged
Perryvw merged 30 commits intoTypeScriptToLua:new-functionsfrom Dec 14, 2018
Merged
New functions - return values and context inference#304Perryvw merged 30 commits intoTypeScriptToLua:new-functionsfrom
Perryvw merged 30 commits intoTypeScriptToLua:new-functionsfrom
Conversation
…gning to untyped vars
…ing functions as arguments or return values
Perryvw
approved these changes
Dec 13, 2018
src/TSHelper.ts
Outdated
| } | ||
| } | ||
|
|
||
| public static getFunctionReturnType(node: ts.Node, checker: ts.TypeChecker): ts.Type { |
Member
There was a problem hiding this comment.
Maybe something like getContainingFunctionReturnType would be clearer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return values are now run through validateAssignment so that methods can't be returned as functions and vice-versa.
Function expressions passed as arguments can have their context type inferred now.
Same for return values:
Note that more complex cases will still fail to to properly infer the context type: