X Tutup
Skip to content

Lualib omit when unused #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 2 commits into from
Nov 11, 2018
Merged

Lualib omit when unused #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5418e1
lualib inline omit header when no features are used
hazzard993 Nov 10, 2018
83a1794
Tests to enforce no lualib text when unused, unless using always
hazzard993 Nov 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Transpiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ export abstract class LuaTranspiler {
}

// Inline lualib features
if (this.options.luaLibImport === LuaLibImportKind.Inline) {
if (this.options.luaLibImport === LuaLibImportKind.Inline && this.luaLibFeatureSet.size > 0) {
result += "\n" + "-- Lua Library Imports\n";
for (const feature of this.luaLibFeatureSet) {
const featureFile = path.resolve(__dirname, `../dist/lualib/${feature}.lua`);
Expand Down
21 changes: 12 additions & 9 deletions test/unit/modules.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,6 @@ export class LuaModuleTests {
Expect(lua.startsWith(`require("lualib_bundle")`));
}

@Test("lualibRequireNoUses")
public lualibRequireNoUses(): void {
// Transpile
const lua = util.transpileString(``, { luaLibImport: LuaLibImportKind.Require, luaTarget: LuaTarget.LuaJIT });

// Assert
Expect(lua).toBe(``);
}

@Test("lualibRequireAlways")
public lualibRequireAlways(): void {
// Transpile
Expand Down Expand Up @@ -63,4 +54,16 @@ export class LuaModuleTests {

Expect(result).toBe(3);
}

@TestCase(LuaLibImportKind.Inline)
@TestCase(LuaLibImportKind.None)
@TestCase(LuaLibImportKind.Require)
@Test("LuaLib no uses? No code")
public lualibNoUsesNoCode(impKind: LuaLibImportKind): void {
// Transpile
const lua = util.transpileString(``, { luaLibImport: impKind });

// Assert
Expect(lua).toBe(``);
}
}
X Tutup