X Tutup
Skip to content

Function apply without arguments should not lead to exception #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 1 commit into from
Mar 12, 2022
Merged

Function apply without arguments should not lead to exception #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/transformation/builtins/function.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,8 @@ export function transformFunctionPrototypeCall(
const expressionName = expression.name.text;
switch (expressionName) {
case "apply":
return lua.createCallExpression(
caller,
[params[0], createUnpackCall(context, params[1], node.arguments[1])],
node
);
const nonContextArgs = params.length > 1 ? [createUnpackCall(context, params[1], node.arguments[1])] : [];
return lua.createCallExpression(caller, [params[0], ...nonContextArgs], node);
case "bind":
return transformLuaLibFunction(context, LuaLibFeature.FunctionBind, node, caller, ...params);
case "call":
Expand Down
8 changes: 8 additions & 0 deletions test/unit/functions/functions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,14 @@ test("Function apply", () => {
`.expectToMatchJsResult();
});

// Fix #1226: https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1226
test("function apply without arguments should not lead to exception", () => {
util.testFunction`
const f = function (this: number) { return this + 3; }
return f.apply(4);
`.expectToMatchJsResult();
});

test("Function call", () => {
util.testFunction`
const abc = function (this: { a: number }, a: string) { return this.a + a; }
Expand Down
X Tutup