Fix nullish coalescing and conditionals when using generics#1191
Merged
Perryvw merged 2 commits intoTypeScriptToLua:masterfrom Dec 21, 2021
Merged
Fix nullish coalescing and conditionals when using generics#1191Perryvw merged 2 commits intoTypeScriptToLua:masterfrom
Perryvw merged 2 commits intoTypeScriptToLua:masterfrom
Conversation
Perryvw
reviewed
Dec 20, 2021
test/unit/conditionals.spec.ts
Outdated
| return ternary(true, ${trueVal}, "wasFalse") | ||
| ` | ||
| .setOptions({ | ||
| strict: true, |
Member
There was a problem hiding this comment.
What is the reason for adding this strict here?
Contributor
Author
There was a problem hiding this comment.
if its not strict, in the old logic, due to any object possibly being null, it will always use an if statement, and so the current logic is not tested (wasn't previously a failing test).
I could change this to strictNullChecks to be more clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1184