Implemented support for properties on functions#1180
Merged
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom Dec 2, 2021
Merged
Implemented support for properties on functions#1180Perryvw merged 1 commit intoTypeScriptToLua:masterfrom
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom
Conversation
Perryvw
reviewed
Dec 2, 2021
| case "call": | ||
| return lua.createCallExpression(caller, params, node); | ||
| default: | ||
| case "toString": |
Member
There was a problem hiding this comment.
This seems like a mistake, this should be default to catch everything we have not handled
Collaborator
Author
There was a problem hiding this comment.
Since functions can have any properties, we don't want to throw errors on them being used. So I changed this to only error on JS lib functions that we don't handle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #388
Functions with properties are now supported (including via declaration merging with namespaces). This is done by wrapping the function definition in a "callable" table (using the
__callmetamethod).Example:
Additionally, this fixes #1174 and fixes #1179 as I needed those working for tests.