fixed vararg optimization logic#1046
Merged
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom Jul 16, 2021
Merged
Conversation
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core flaw in how this was working is that any function types defined inside the scope would be flagged as "hoistable" and trigger deoptimization. But this would include things like parameters or local variable types.
I've changed this logic to explicitly only include actual hoistable functions (ex.
function foo() {}) which seems to address all cases properly now. We should keep our eye out for other edge cases here, though.Closes #1047