-
-
Notifications
You must be signed in to change notification settings - Fork 184
Expand file tree
/
Copy pathdecorators.spec.ts
More file actions
648 lines (555 loc) · 19.3 KB
/
decorators.spec.ts
File metadata and controls
648 lines (555 loc) · 19.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
import {
decoratorInvalidContext,
incompleteFieldDecoratorWarning,
} from "../../../src/transformation/utils/diagnostics";
import * as util from "../../util";
test("Class decorator with no parameters", () => {
util.testFunction`
let classDecoratorContext;
function classDecorator<T extends new (...args: any[]) => {}>(constructor: T, context: ClassDecoratorContext) {
classDecoratorContext = context;
return class extends constructor {
decoratorBool = true;
}
}
@classDecorator
class TestClass {
public decoratorBool = false;
}
return { decoratedClass: new TestClass(), context: {
kind: classDecoratorContext.kind,
name: classDecoratorContext.name,
} };
`.expectToMatchJsResult();
});
test("Class decorator with parameters", () => {
util.testFunction`
function setNum(numArg: number) {
return <T extends new (...args: any[]) => {}>(constructor: T, context: ClassDecoratorContext) => {
return class extends constructor {
decoratorNum = numArg;
};
};
}
@setNum(420)
class TestClass {
public decoratorNum;
}
return new TestClass();
`.expectToMatchJsResult();
});
test("Multiple class decorators", () => {
util.testFunction`
function setTen<T extends new (...args: any[]) => {}>(constructor: T, context: ClassDecoratorContext) {
return class extends constructor {
decoratorTen = 10;
}
}
function setNum<T extends new (...args: any[]) => {}>(constructor: T, context: ClassDecoratorContext) {
return class extends constructor {
decoratorNum = 410;
}
}
@setTen
@setNum
class TestClass {
public decoratorTen;
public decoratorNum;
}
return new TestClass();
`.expectToMatchJsResult();
});
test("Class decorator with inheritance", () => {
util.testFunction`
function setTen<T extends new (...args: any[]) => {}>(constructor: T, context: ClassDecoratorContext) {
return class extends constructor {
decoratorTen = 10;
}
}
class TestClass {
public decoratorTen = 0;
}
@setTen
class SubTestClass extends TestClass {
public decoratorTen = 5;
}
return new SubTestClass();
`.expectToMatchJsResult();
});
test("Class decorators are applied in order and executed in reverse order", () => {
util.testFunction`
const order = [];
function pushOrder(index: number) {
order.push("eval " + index);
return (constructor: new (...args: any[]) => {}, context: ClassDecoratorContext) => {
order.push("execute " + index);
};
}
@pushOrder(1)
@pushOrder(2)
@pushOrder(3)
class TestClass {}
return order;
`.expectToMatchJsResult();
});
test("Throws error if decorator function has void context", () => {
util.testFunction`
function decorator(this: void, constructor: new (...args: any[]) => {}, context: ClassDecoratorContext) {}
@decorator
class TestClass {}
`.expectDiagnosticsToMatchSnapshot([decoratorInvalidContext.code]);
});
test("Exported class decorator", () => {
util.testModule`
function decorator<T extends new (...args: any[]) => any>(Class: T, context: ClassDecoratorContext): T {
return class extends Class {
public bar = "foobar";
};
}
@decorator
export class Foo {}
`
.setReturnExport("Foo", "bar")
.expectToMatchJsResult();
});
// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1149
test("exported class with decorator (#1149)", () => {
util.testModule`
import { MyClass } from "./other";
const inst = new MyClass();
export const result = inst.foo();
`
.addExtraFile(
"other.ts",
`function myDecorator(target: {new(): any}, context: ClassDecoratorContext) {
return class extends target {
foo() {
return "overridden";
}
}
}
@myDecorator
export class MyClass {
foo() {
return "foo";
}
}`
)
.expectToEqual({ result: "overridden" });
});
// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1634
test("namespaced exported class with decorator (#1634)", () => {
util.testModule`
function myDecorator(target: {new(): any}, context: ClassDecoratorContext) {
return class extends target {
foo() {
return "overridden";
}
}
}
namespace ns {
@myDecorator
export class MyClass {
foo() {
return "foo";
}
}
}
`.expectNoExecutionError();
});
test("default exported class with decorator", () => {
util.testModule`
import MyClass from "./other";
const inst = new MyClass();
export const result = inst.foo();
`
.addExtraFile(
"other.ts",
`function myDecorator(target: {new(): any}, context: ClassDecoratorContext) {
return class extends target {
foo() {
return "overridden";
}
}
}
@myDecorator
export default class {
foo() {
return "foo";
}
}`
)
.expectToEqual({ result: "overridden" });
});
test("class method decorator", () => {
util.testFunction`
let methodDecoratorContext;
function methodDecorator(method: (v: number) => number, context: ClassMethodDecoratorContext) {
methodDecoratorContext = context;
return (v: number) => {
return method(v) + 10;
};
}
class TestClass {
@methodDecorator
public myMethod(x: number) {
return x * 23;
}
}
return { result: new TestClass().myMethod(4), context: {
kind: methodDecoratorContext.kind,
name: methodDecoratorContext.name,
private: methodDecoratorContext.private,
static: methodDecoratorContext.static
} };
`.expectToMatchJsResult();
});
test("this in decorator points to class being decorated", () => {
util.testFunction`
function methodDecorator(method: (v: number) => number, context: ClassMethodDecoratorContext) {
return function() {
const thisCallTime = this.myInstanceVariable;
return thisCallTime;
};
}
class TestClass {
constructor(protected myInstanceVariable: number) { }
@methodDecorator
public myMethod() {
return 0;
}
}
return new TestClass(5).myMethod();
`.expectToMatchJsResult();
});
test("class getter decorator", () => {
util.testFunction`
let getterDecoratorContext;
function getterDecorator(getter: () => number, context: ClassGetterDecoratorContext) {
getterDecoratorContext = context;
return () => {
return getter() + 10;
};
}
class TestClass {
@getterDecorator
get getterValue() { return 10; }
}
return { result: new TestClass().getterValue, context: {
kind: getterDecoratorContext.kind,
name: getterDecoratorContext.name,
private: getterDecoratorContext.private,
static: getterDecoratorContext.static
} };
`.expectToMatchJsResult();
});
test("class setter decorator", () => {
util.testFunction`
let setterDecoratorContext;
function setterDecorator(setter: (v: number) => void, context: ClassSetterDecoratorContext) {
setterDecoratorContext = context;
return function(v: number) {
setter.call(this, v + 15);
};
}
class TestClass {
public value: number;
@setterDecorator
set valueSetter(v: number) { this.value = v; }
}
const instance = new TestClass();
instance.valueSetter = 23;
return { result: instance.value, context: {
kind: setterDecoratorContext.kind,
name: setterDecoratorContext.name,
private: setterDecoratorContext.private,
static: setterDecoratorContext.static
} };
`.expectToMatchJsResult();
});
test("class field decorator", () => {
util.testFunction`
let fieldDecoratorContext;
function fieldDecorator(_: undefined, context: ClassFieldDecoratorContext) {
fieldDecoratorContext = context;
}
class TestClass {
@fieldDecorator
public value: number = 22;
}
return { result: new TestClass(), context: {
kind: fieldDecoratorContext.kind,
name: fieldDecoratorContext.name,
private: fieldDecoratorContext.private,
static: fieldDecoratorContext.static,
} };
`.expectToEqual({
result: {
value: 22, // Different from JS because we ignore the value initializer
},
context: {
kind: "field",
name: "value",
private: false,
static: false,
},
});
});
test("class field decorator warns the return value is ignored", () => {
util.testFunction`
let fieldDecoratorContext;
function fieldDecorator(_: undefined, context: ClassFieldDecoratorContext) {
fieldDecoratorContext = context;
return (initialValue: number) => initialValue * 12;
}
class TestClass {
@fieldDecorator
public value: number = 22;
}
`.expectDiagnosticsToMatchSnapshot([incompleteFieldDecoratorWarning.code]);
});
describe("legacy experimentalDecorators", () => {
test("Class decorator with no parameters", () => {
util.testFunction`
function setBool<T extends new (...args: any[]) => {}>(constructor: T) {
return class extends constructor {
decoratorBool = true;
}
}
@setBool
class TestClass {
public decoratorBool = false;
}
return new TestClass();
`
.setOptions({ experimentalDecorators: true })
.expectToMatchJsResult();
});
test("Class decorator with parameters", () => {
util.testFunction`
function setNum(numArg: number) {
return <T extends new (...args: any[]) => {}>(constructor: T) => {
return class extends constructor {
decoratorNum = numArg;
};
};
}
@setNum(420)
class TestClass {
public decoratorNum;
}
return new TestClass();
`
.setOptions({ experimentalDecorators: true })
.expectToMatchJsResult();
});
test("Multiple class decorators", () => {
util.testFunction`
function setTen<T extends new (...args: any[]) => {}>(constructor: T) {
return class extends constructor {
decoratorTen = 10;
}
}
function setNum<T extends new (...args: any[]) => {}>(constructor: T) {
return class extends constructor {
decoratorNum = 410;
}
}
@setTen
@setNum
class TestClass {
public decoratorTen;
public decoratorNum;
}
return new TestClass();
`
.setOptions({ experimentalDecorators: true })
.expectToMatchJsResult();
});
test("Class decorator with inheritance", () => {
util.testFunction`
function setTen<T extends new (...args: any[]) => {}>(constructor: T) {
return class extends constructor {
decoratorTen = 10;
}
}
class TestClass {
public decoratorTen = 0;
}
@setTen
class SubTestClass extends TestClass {
public decoratorTen = 5;
}
return new SubTestClass();
`
.setOptions({ experimentalDecorators: true })
.expectToMatchJsResult();
});
test("Class decorators are applied in order and executed in reverse order", () => {
util.testFunction`
const order = [];
function pushOrder(index: number) {
order.push("eval " + index);
return (constructor: new (...args: any[]) => {}) => {
order.push("execute " + index);
};
}
@pushOrder(1)
@pushOrder(2)
@pushOrder(3)
class TestClass {}
return order;
`
.setOptions({ experimentalDecorators: true })
.expectToMatchJsResult();
});
test("Throws error if decorator function has void context", () => {
util.testFunction`
function decorator(this: void, constructor: new (...args: any[]) => {}) {}
@decorator
class TestClass {}
`
.setOptions({ experimentalDecorators: true })
.expectDiagnosticsToMatchSnapshot([decoratorInvalidContext.code]);
});
test("Exported class decorator", () => {
util.testModule`
function decorator<T extends new (...args: any[]) => any>(Class: T): T {
return class extends Class {
public bar = "foobar";
};
}
@decorator
export class Foo {}
`
.setReturnExport("Foo", "bar")
.setOptions({ experimentalDecorators: true })
.expectToMatchJsResult();
});
test.each([
["@decorator method() {}"],
["@decorator property;"],
["@decorator propertyWithInitializer = () => {};"],
["@decorator ['evaluated property'];"],
["@decorator get getter() { return 5 }"],
["@decorator set setter(value) {}"],
["@decorator static method() {}"],
["@decorator static property;"],
["@decorator static propertyWithInitializer = () => {}"],
["@decorator static get getter() { return 5 }"],
["@decorator static set setter(value) {}"],
["@decorator static ['evaluated property'];"],
["method(@decorator a) {}"],
["static method(@decorator a) {}"],
["constructor(@decorator a) {}"],
])("Decorate class member (%p)", classMember => {
util.testFunction`
let decoratorParameters: any;
const decorator = (target, key, index?) => {
const targetKind = target === Foo ? "Foo" : target === Foo.prototype ? "Foo.prototype" : "unknown";
decoratorParameters = { targetKind, key, index: typeof index };
};
class Foo {
${classMember}
}
return decoratorParameters;
`
.setOptions({ experimentalDecorators: true })
.expectToMatchJsResult();
});
describe("Decorators /w descriptors", () => {
test.each([
["return { writable: true }", "return { configurable: true }"],
["desc.writable = true", "return { configurable: true }"],
])("Combine decorators (%p + %p)", (decorateA, decorateB) => {
util.testFunction`
const A = (target, key, desc): any => { ${decorateA} };
const B = (target, key, desc): any => { ${decorateB} };
class Foo { @A @B static method() {} }
const { value, ...rest } = Object.getOwnPropertyDescriptor(Foo, "method");
return rest;
`
.setOptions({ experimentalDecorators: true })
.expectToMatchJsResult();
});
test.each(["return { value: true }", "desc.value = true"])(
"Use decorator to override method value %s",
overrideStatement => {
util.testFunction`
const decorator = (target, key, desc): any => { ${overrideStatement} };
class Foo { @decorator static method() {} }
return Foo.method;
`
.setOptions({ experimentalDecorators: true })
.expectToMatchJsResult();
}
);
});
// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1149
test("exported class with decorator", () => {
util.testModule`
import { MyClass } from "./other";
const inst = new MyClass();
export const result = inst.foo();
`
.addExtraFile(
"other.ts",
`function myDecorator(target: {new(): any}) {
return class extends target {
foo() {
return "overridden";
}
}
}
@myDecorator
export class MyClass {
foo() {
return "foo";
}
}`
)
.setOptions({ experimentalDecorators: true })
.expectToEqual({ result: "overridden" });
});
test("default exported class with decorator", () => {
util.testModule`
import MyClass from "./other";
const inst = new MyClass();
export const result = inst.foo();
`
.addExtraFile(
"other.ts",
`function myDecorator(target: {new(): any}) {
return class extends target {
foo() {
return "overridden";
}
}
}
@myDecorator
export default class {
foo() {
return "foo";
}
}`
)
.setOptions({ experimentalDecorators: true })
.expectToEqual({ result: "overridden" });
});
// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1453
test("Class methods with legacy decorators can still be called ($1453)", () => {
util.testFunction`
function decorator<Class>(
target: Class,
propertyKey: keyof Class,
): void {}
class Foo {
@decorator
public method2() { return 4; }
}
return new Foo().method2();
`
.setOptions({ experimentalDecorators: true })
.expectToMatchJsResult();
});
});